AMR for ElementSubdomainModifier #19519

fdkong · 2021-12-01T20:24:20Z

Closes #20387

fdkong · 2021-12-01T22:52:41Z

loganharbour · 2021-12-01T23:57:36Z

framework/include/markers/ErrorFractionMarker.h

@@ -27,15 +27,16 @@ class ErrorFractionMarker : public IndicatorMarker

 protected:
  virtual MarkerValue computeElementMarker() override;
+  bool checkElementSubdomainConsistent(const Elem * const & _current_elem);


Suggested change

bool checkElementSubdomainConsistent(const Elem * const & _current_elem);

bool checkSubdomainConsistency(const Elem & elem) const;

also add docstring

loganharbour · 2021-12-01T23:58:28Z

framework/include/markers/ErrorFractionMarker.h


  Real _coarsen;
  Real _refine;
  bool _clear_extremes;
+  bool _is_subdomain_consistent;


Suggested change

bool _is_subdomain_consistent;

// Whether or not to check the consistency of subdomain ids when coarsening

const bool _check_subdomain_consistency;

loganharbour · 2021-12-02T00:00:12Z

framework/src/userobject/ElementSubdomainModifier.C

+
+    // Change the parent's subdomain, if any
+    // We do not save the parent info since they are inactive
+    setAncestorsSubdomainIDs(subdomain_id, elem_id);


Suggested change

setAncestorsSubdomainIDs(subdomain_id, elem_id);

setAncestorsSubdomainIDs(*elem);

loganharbour · 2021-12-02T00:05:55Z

framework/src/userobject/ElementSubdomainModifier.C

+void
+ElementSubdomainModifier::setAncestorsSubdomainIDs(const SubdomainID & subdomain_id,


This should be:

void ElementSubdomainModifier::setAncestorsSubdomainIDs(Elem & elem) const { Elem * current_elem = &elem; unsigned int lv = current_elem->level(); for (unsigned int i = lv; i > 0; --i) { current_elem = curent_elem->parent(); current_elem->subdomain_id() = elem.subdomain_id(); // displaced parent element Elem * displaced_elem = _displaced_problem ? _displaced_problem->mesh().elemPtr(id) : nullptr; if (displaced_elem) displaced_elem->subdomain_id() = elem.subdomain_id(); } }

There's no need to ever call _mesh.elemPtr(). current_elem->parent() should return a non-const elem because current_elem is non const

framework/src/markers/ErrorFractionMarker.C

fdkong · 2022-02-23T22:35:02Z

Need libmesh update libMesh/libmesh#3094

moosebuild · 2022-02-23T23:42:28Z

libmesh

@@ -1 +1 @@
-Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
+Subproject commit f2940e0fcffcb81301cd14c88088a09727b55ebe


Caution! This contains a submodule update

moosebuild · 2022-02-24T00:25:46Z

libmesh

@@ -1 +1 @@
-Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
+Subproject commit f2940e0fcffcb81301cd14c88088a09727b55ebe


Caution! This contains a submodule update

moosebuild · 2022-02-24T01:11:21Z

libmesh

@@ -1 +1 @@
-Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
+Subproject commit f2940e0fcffcb81301cd14c88088a09727b55ebe


Caution! This contains a submodule update

moosebuild · 2022-02-24T02:55:38Z

Job Documentation on 628b8cf wanted to post the following:

View the site here

This comment will be updated on new commits.

loganharbour

Warning: This PR changes repo size by 6.43 MiB.

way too much for only a few tests

fdkong · 2022-02-24T17:31:52Z

Warning: This PR changes repo size by 6.43 MiB.

way too much for only a few tests

I will try to make the mesh smaller ....

loganharbour · 2022-02-24T17:33:13Z

I've got a partial review going for this from december, give me a ping @fdkong when you're ready

fdkong · 2022-02-24T17:34:29Z

I need to add more tests.

Do not allow coarsening on the moving boundary and an element and its siblings have different subdomain ids

…difier

moosebuild · 2022-02-24T21:44:22Z

libmesh

@@ -1 +1 @@
-Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
+Subproject commit f2940e0fcffcb81301cd14c88088a09727b55ebe


Caution! This contains a submodule update

Closes idaholab#20387

…n modifier Closes idaholab#20387

moosebuild · 2022-02-24T22:04:42Z

libmesh

@@ -1 +1 @@
-Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
+Subproject commit 0c01ac73068bbf19891001680c44ec6b6d0420b8


Caution! This contains a submodule update

We did this tmp update to check if the code still works

moosebuild · 2022-02-24T22:45:15Z

libmesh

@@ -1 +1 @@
-Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
+Subproject commit 0c01ac73068bbf19891001680c44ec6b6d0420b8


Caution! This contains a submodule update

moosebuild · 2022-02-24T22:45:21Z

Job Precheck on 628b8cf wanted to post the following:

The following file(s) are changed:

conda/libmesh/meta.yaml

The libmesh conda configuration has changed; ping @idaholab/moose-dev-ops

github-actions · 2022-03-27T05:43:22Z

This pull request has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in 3 days if no further activity occurs. Thank you for your contributions.

fdkong marked this pull request as draft December 1, 2021 20:54

loganharbour requested changes Dec 2, 2021

View reviewed changes

loganharbour assigned fdkong Dec 7, 2021

fdkong force-pushed the amr_for_am_1 branch from 772e2ee to 6eb40b1 Compare January 13, 2022 00:46

fdkong changed the title ~~WIP: AMR for CoupledVarThresholdElementSubdomainModifier~~ AMR for ElementSubdomainModifier Feb 23, 2022

fdkong force-pushed the amr_for_am_1 branch from 71dd59b to 425a10c Compare February 23, 2022 23:37

moosebuild reviewed Feb 23, 2022

View reviewed changes

fdkong force-pushed the amr_for_am_1 branch from 425a10c to 2795b0f Compare February 24, 2022 00:20

moosebuild reviewed Feb 24, 2022

View reviewed changes

loganharbour requested changes Feb 24, 2022

View reviewed changes

fdkong and others added 5 commits February 24, 2022 12:26

AMR for CoupledVarThresholdElementSubdomainModifier

c515830

Do not allow coarsening on the moving boundary and an element and its siblings have different subdomain ids

Change moved element's ancestors' subdomain IDs in ElementSubdomainMo…

f76be0e

…difier

Fix for boundary info in ElementSubdomainModifier

ea93791

Add test case

3388e39

Clear up old moving boundary

b3c5f5d

fdkong force-pushed the amr_for_am_1 branch from 4f28390 to 5ca3020 Compare February 24, 2022 21:40

moosebuild reviewed Feb 24, 2022

View reviewed changes

fdkong added 6 commits February 24, 2022 14:47

An initial draft that works for moving boundary

b1096e5

Add code comments for ElementSubdomainModifier

6eb2195

Applied clang-format

b2455aa

Added BoundaryPreservedMarker

3cd9b2b

Moving boundary worked for 3D problems

0ebfac3

Delete extra code from ErrorFractionMarker

8b1d860

fdkong added 6 commits February 24, 2022 14:47

Added a 2D moving-boundary example

1f82d55

Closes idaholab#20387

Added a 3D test case for AMR with moving boundary in element subdomai…

7894a92

…n modifier Closes idaholab#20387

Added documentation for BoundaryPreservedMarker

3df92f7

Added tests for BC application on moving boundary

ce8a9c7

Added a ntegral BC test for the element subdomain modifier

486654e

Reduced problem size of adaptivity_moving_boundary_3d

861295f

fdkong force-pushed the amr_for_am_1 branch from 5ca3020 to 73f641c Compare February 24, 2022 21:59

moosebuild reviewed Feb 24, 2022

View reviewed changes

Update libmesh

628b8cf

We did this tmp update to check if the code still works

fdkong force-pushed the amr_for_am_1 branch from 73f641c to 628b8cf Compare February 24, 2022 22:38

moosebuild reviewed Feb 24, 2022

View reviewed changes

github-actions bot added the stale PRs that have reached or exceeded 90 days with no activity label Mar 27, 2022

github-actions bot closed this Mar 31, 2022

fdkong mentioned this pull request Apr 5, 2022

AMR for ElementSubdomainModifier #20716

Closed

dewenyushu mentioned this pull request Jan 5, 2023

AMR for ElementSubdomainModifier #23078

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AMR for ElementSubdomainModifier #19519

AMR for ElementSubdomainModifier #19519

fdkong commented Dec 1, 2021 •

edited

Loading

fdkong commented Dec 1, 2021

loganharbour Dec 1, 2021 •

edited

Loading

loganharbour Dec 1, 2021 •

edited

Loading

loganharbour Dec 2, 2021

loganharbour Dec 2, 2021

fdkong commented Feb 23, 2022

moosebuild Feb 23, 2022

moosebuild Feb 24, 2022

moosebuild Feb 24, 2022

moosebuild commented Feb 24, 2022 •

edited

Loading

loganharbour left a comment

fdkong commented Feb 24, 2022

loganharbour commented Feb 24, 2022

fdkong commented Feb 24, 2022

moosebuild Feb 24, 2022

moosebuild Feb 24, 2022

moosebuild Feb 24, 2022

moosebuild commented Feb 24, 2022

github-actions bot commented Mar 27, 2022

	bool checkElementSubdomainConsistent(const Elem * const & _current_elem);
	bool checkSubdomainConsistency(const Elem & elem) const;

	bool _is_subdomain_consistent;
	// Whether or not to check the consistency of subdomain ids when coarsening
	const bool _check_subdomain_consistency;

	setAncestorsSubdomainIDs(subdomain_id, elem_id);
	setAncestorsSubdomainIDs(*elem);

		void
		ElementSubdomainModifier::setAncestorsSubdomainIDs(const SubdomainID & subdomain_id,

		@@ -1 +1 @@
		Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
		Subproject commit f2940e0fcffcb81301cd14c88088a09727b55ebe

		@@ -1 +1 @@
		Subproject commit 544e2c87ea2f35aab900dde8b8f1e0926d720421
		Subproject commit 0c01ac73068bbf19891001680c44ec6b6d0420b8

AMR for ElementSubdomainModifier #19519

AMR for ElementSubdomainModifier #19519

Conversation

fdkong commented Dec 1, 2021 • edited Loading

fdkong commented Dec 1, 2021

loganharbour Dec 1, 2021 • edited Loading

Choose a reason for hiding this comment

loganharbour Dec 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fdkong commented Feb 23, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moosebuild commented Feb 24, 2022 • edited Loading

loganharbour left a comment

Choose a reason for hiding this comment

fdkong commented Feb 24, 2022

loganharbour commented Feb 24, 2022

fdkong commented Feb 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moosebuild commented Feb 24, 2022

github-actions bot commented Mar 27, 2022

fdkong commented Dec 1, 2021 •

edited

Loading

loganharbour Dec 1, 2021 •

edited

Loading

loganharbour Dec 1, 2021 •

edited

Loading

moosebuild commented Feb 24, 2022 •

edited

Loading