New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Navier Stokes FV action that handles different types of runs. #20043
Conversation
Job Documentation on 8329bd2 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on 8329bd2 wanted to post the following: Framework coverage
Modules coverageNavier stokes
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
074ca96
to
92c11a0
Compare
b102656
to
127f9d5
Compare
@grmnptr please re-request review when you're ready for it. I'm going to unsubscribe from this for now |
Job Linux stack on 8efd8f0 : invalidated by @grmnptr |
Job Test install on 8efd8f0 : invalidated by @grmnptr |
Job Modules parallel on 8efd8f0 : invalidated by @grmnptr |
Job Framework 1 on 8efd8f0 : invalidated by @grmnptr |
Job Python 3.8 on 8efd8f0 : invalidated by @grmnptr |
Job Python 3.7 on 8efd8f0 : invalidated by @grmnptr |
Job App documentation on 8efd8f0 : invalidated by @grmnptr |
Job Python 3.8 on 8efd8f0 : invalidated by @grmnptr |
Job App documentation on 8efd8f0 : invalidated by @grmnptr |
1 similar comment
Job App documentation on 8efd8f0 : invalidated by @grmnptr |
modules/navier_stokes/doc/content/syntax/Modules/NavierStokesFV/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
b6e39bc
to
24630ab
Compare
Hitting
with a number for specific heat.
Let's error if:
I m still diverging in the main input with restart. Trying to understand why |
The constant density input is also an issue for PINSFV right now:
it's the same check as for cp though. Maybe we should have a helper routine at this point |
…e to make it cleaner refs idaholab#20043
Refs. (#19472)
Reason
This PR is supposed to add finite-volume specific Navier Stokes action which can create different types of runs (WC/IC/PWC/PIC) without the need of users setting up convoluted runs.
Design
Add NSFVAction class which can handle the kernels/setting itself.
Impact
Would potentially decrease the confusion of what kernel is used in what context. This would also decrease user errors in the input files and simplify finite-volume specific Navier Stokes input syntax.