Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Navier Stokes FV action that handles different types of runs. #20043

Merged
merged 96 commits into from Apr 21, 2022

Conversation

grmnptr
Copy link
Contributor

@grmnptr grmnptr commented Jan 13, 2022

Refs. (#19472)

Reason

This PR is supposed to add finite-volume specific Navier Stokes action which can create different types of runs (WC/IC/PWC/PIC) without the need of users setting up convoluted runs.

Design

Add NSFVAction class which can handle the kernels/setting itself.

Impact

Would potentially decrease the confusion of what kernel is used in what context. This would also decrease user errors in the input files and simplify finite-volume specific Navier Stokes input syntax.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 13, 2022

Job Documentation on 8329bd2 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 13, 2022

Job Coverage on 8329bd2 wanted to post the following:

Framework coverage

e9d199 #20043 8329bd
Total Total +/- New
Rate 82.60% 82.60% -0.00% 0.00%
Hits 74288 74287 -1 0
Misses 15647 15651 +4 3

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

e9d199 #20043 8329bd
Total Total +/- New
Rate 83.71% 85.15% +1.44% 96.71%
Hits 8451 9646 +1195 1264
Misses 1644 1682 +38 43

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

@lindsayad
Copy link
Member

@grmnptr please re-request review when you're ready for it. I'm going to unsubscribe from this for now

@moosebuild
Copy link
Contributor

Job Linux stack on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job Test install on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job Modules parallel on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job Framework 1 on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job Python 3.8 on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job Python 3.7 on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job App documentation on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job Python 3.8 on 8efd8f0 : invalidated by @grmnptr

@moosebuild
Copy link
Contributor

Job App documentation on 8efd8f0 : invalidated by @grmnptr

1 similar comment
@moosebuild
Copy link
Contributor

Job App documentation on 8efd8f0 : invalidated by @grmnptr

@grmnptr grmnptr marked this pull request as ready for review March 4, 2022 18:08
@GiudGiud
Copy link
Contributor

GiudGiud commented Apr 20, 2022

Hitting

*** ERROR ***
The following error occurred in the object "MOOSE Problem", of type "FEProblem".

No functor ever provided with name '1594', which was requested by 'MOOSE Problem'.

with a number for specific heat.

  • we should be able to set the Prandtl number (we set it to 10 in the MSFR, after Lane mentioned 1 was low-ish)

Let's error if:

  • energy equation is not set to true yet some parameters (specific heat / thermal diffusivity / wall types / inlets) are passed for it. Careful with the Boussinesq parameters, we may want to segregate the thermal solve so still allow them
  • turbulence model is not set (or set to none) yet some parameters are passed for it
  • no scalars are specified to the model yet some parameters are passed for it (for example the interpolation parameters)

I m still diverging in the main input with restart. Trying to understand why

@GiudGiud
Copy link
Contributor

The constant density input is also an issue for PINSFV right now:

*** ERROR ***
The following error occurred in the object "MOOSE Problem", of type "FEProblem".

No functor ever provided with name 'd1970.0_dt', which was requested by 'pins_energy_time'.

it's the same check as for cp though. Maybe we should have a helper routine at this point

@lindsayad lindsayad merged commit 3bf6ac5 into idaholab:next Apr 21, 2022
GiudGiud added a commit to GiudGiud/moose that referenced this pull request Jun 20, 2022
GiudGiud added a commit to GiudGiud/moose that referenced this pull request Jun 20, 2022
GiudGiud added a commit to GiudGiud/moose that referenced this pull request Jun 24, 2022
@lindsayad lindsayad mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants