Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action for INSFV #16283

Closed
lindsayad opened this issue Nov 23, 2020 · 1 comment
Closed

Action for INSFV #16283

lindsayad opened this issue Nov 23, 2020 · 1 comment
Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@lindsayad
Copy link
Member

lindsayad commented Nov 23, 2020 •
edited
Loading

Reason

INSFV input files can be quite verbose. Having an action would significantly reduce this.

Design

Should use same type of syntax introduced in #15305

Impact

Make INSFV much more usable and less daunting/confusing for new users. Additionally it will allow us to encapsulate the (I)NSFV design more.
@lindsayad lindsayad added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules labels Nov 23, 2020
@lindsayad lindsayad mentioned this issue Nov 23, 2020
Merged
4 tasks
@lindsayad lindsayad mentioned this issue Feb 3, 2021
Closed
@loganharbour loganharbour added C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module and removed C: Modules labels Jan 4, 2022
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 13, 2022
@GiudGiud
Add more information about sizes in NSFV param size error messages, r…
5f57035 
…efs #

refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 13, 2022
@GiudGiud
Add more information about sizes in NSFV param size error messages, r…
8711920 
…efs #

refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 13, 2022
@GiudGiud
Add more information about sizes in NSFV param size error messages, r…
f4b537f 
…efs #

refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 14, 2022
@GiudGiud @lindsayad
Add more information about sizes in NSFV param size error messages, r…
c5f865c 
…efs #

refs idaholab#16283

Apply suggestions from code review

Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 14, 2022
@GiudGiud @lindsayad
Add more information about sizes in NSFV param size error messages refs
ee2d963 
idaholab#16283

Apply suggestions from code review

Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 14, 2022
@GiudGiud @lindsayad
Add more information about sizes in NSFV param size error messages refs
3775cc1 
idaholab#16283

Apply suggestions from code review

Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 14, 2022
@GiudGiud @lindsayad
Add more information about sizes in NSFV param size error messages refs
45ad535 
idaholab#16283

Apply suggestions from code review

Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
crb3874 pushed a commit to crb3874/moose_colin that referenced this issue Jun 27, 2022
@GiudGiud @lindsayad @crb3874
Add more information about sizes in NSFV param size error messages refs
068fc9c 
idaholab#16283

Apply suggestions from code review

Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 9, 2022
@GiudGiud
Only add the gravity term for the directions where gravity is non-nul…
0c212af 
…l, refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 13, 2022
@GiudGiud
Only add the gravity term for the directions where gravity is non-nul…
77f9733 
…l, refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 13, 2022
@GiudGiud
Only add the gravity term for the directions where gravity is non-nul…
6a3b2a8 
…l, refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 13, 2022
@GiudGiud
Only add the gravity term for the directions where gravity is non-nul…
1a59ceb 
…l, refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 14, 2022
@GiudGiud
Only add the gravity term for the directions where gravity is non-nul…
fe172d2 
…l, refs idaholab#16283
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 16, 2022
@GiudGiud
Only add the gravity term for the directions where gravity is non-nul…
0ee4da3 
…l, refs idaholab#16283
@lindsayad
Copy link
Member Author

Closed by #20043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindsayad @loganharbour