New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FVFunctorDirichletBC #21377
Add FVFunctorDirichletBC #21377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's roll without AD for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could force users to be more conscientious about this by only taking a Real
functor, which would necessitate creating a conversion functor material property. This would prevent accidental use of nonlinear variables for example.
I don't have a strong preference on this though
Yeah that seems fine to me too, but AuxVariables are ADFunctors too so that's that. If we do that change, let's add that conversion story in the documentation for the FunctorDirichletBC |
If we could at some point make an aux variable inherit from |
Job Documentation on 69ac1c1 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on 69ac1c1 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
…upport AD-Dirichlet fully refs idaholab#21374
Reason
Use functors to set BCs is required if the information comes from a transfer from a different app.
Design
An FV Dirichlet boundary condition that takes a functor name as parameter and evaluates it to set the boundary
value
Impact
New capability.
Caveat: @GiudGiud @lindsayad
FVDirichletBC
return only Reals, not ADReals. This is ok for my use case (MultiApp transfers lose derivative info anyway), but in general someone could abuse this.