Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FVFunctorDirichletBC #21377

Merged
merged 2 commits into from Jun 22, 2022
Merged

Add FVFunctorDirichletBC #21377

merged 2 commits into from Jun 22, 2022

Conversation

snschune
Copy link
Contributor

Reason

Use functors to set BCs is required if the information comes from a transfer from a different app.

Design

An FV Dirichlet boundary condition that takes a functor name as parameter and evaluates it to set the boundary
value

Impact

New capability.

Caveat: @GiudGiud @lindsayad FVDirichletBC return only Reals, not ADReals. This is ok for my use case (MultiApp transfers lose derivative info anyway), but in general someone could abuse this.

@snschune snschune requested a review from lindsayad as a code owner June 21, 2022 20:39
@snschune snschune changed the title Add FVFunctorDirichletBC with doco and test (#21374) Add FVFunctorDirichletBC Jun 21, 2022
GiudGiud
GiudGiud previously approved these changes Jun 21, 2022
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's roll without AD for now

Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could force users to be more conscientious about this by only taking a Real functor, which would necessitate creating a conversion functor material property. This would prevent accidental use of nonlinear variables for example.

I don't have a strong preference on this though

@GiudGiud
Copy link
Contributor

Yeah that seems fine to me too, but AuxVariables are ADFunctors too so that's that.

If we do that change, let's add that conversion story in the documentation for the FunctorDirichletBC

@lindsayad
Copy link
Member

If we could at some point make an aux variable inherit from Functor<Real>, that would be nice

@moosebuild
Copy link
Contributor

moosebuild commented Jun 21, 2022

Job Documentation on 69ac1c1 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jun 21, 2022

Job Coverage on 69ac1c1 wanted to post the following:

Framework coverage

41e7a8 #21377 69ac1c
Total Total +/- New
Rate 83.48% 83.48% -0.00% 100.00%
Hits 77407 77413 +6 10
Misses 15318 15322 +4 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants