New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SymmetryTransformerGenerator, with plane symmetry only currently #21718
Add SymmetryTransformerGenerator, with plane symmetry only currently #21718
Conversation
492bbba
to
38e3ef1
Compare
This is on hold until we can get better fixing of negative volumes in libmesh |
bfc5caf
to
a67e406
Compare
This will be near-ready on the next libmesh submodule update. |
a67e406
to
924264b
Compare
924264b
to
23ee722
Compare
@loganharbour this should be ready for review please |
nevermind still no libmesh update |
Beware, the option to optionally use StitchedMeshGenerator has not been tested. Tests have not been written. I would appreciate it if the test currently in simple.i would end up in the documentation as an example of what default parameters are ran when the stitch option is exercised.
- change to Transform instead of Transformer - add parameter name for stitching - less docs on issue of normalizing vector and just tell user what is happening refs idaholab#21578
23ee722
to
bc9c9f8
Compare
@loganharbour ready for review. I've had to add a bit of lower quality code (const_cast) to allow for a sub-generator to run after a main generator. |
…ransform, to sitich the output meshes, refs idaholab#21578
bc9c9f8
to
2f17d47
Compare
Job Documentation on 917e4f8 wanted to post the following: View the site here This comment will be updated on new commits. |
2f17d47
to
0b2bbdf
Compare
Job Coverage on 917e4f8 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really against the subgenerator for a few reasons:
- The implementation of the before action is poor. This is resolvable and thus is minor.
- I think that it will be confusing if we allow the addition of subgens like this. We could end up in a position where we could end up with a wonky graph that isn't intuitive to debug.
- The action of the stitching is so simple and only requires copying one input to another in another MG. I think it's a poor use of the subgenerator system. It makes it look like we're okay with having a ton of meta generators - which I think is a poor idea because the best part of the MG system is its pluggability, and having to maintain all of that meta interaction sounds awful.
0b2bbdf
to
48111e4
Compare
Should be good now |
48111e4
to
76756c6
Compare
- Remove stitching from symmetry generator - more constness - use paramError over mooseError when possible
76756c6
to
917e4f8
Compare
Thanks for the contribution @RocksSavage ! |
Beware, the option to optionally use StitchedMeshGenerator has not been tested. Tests have not been written.
I would appreciate it if the test currently in simple.i would end up in the documentation as an example of what
default parameters are ran when the stitch option is exercised.
Refs #21578