New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poly2TriMeshGenerator, upgraded and rebased #21800
Poly2TriMeshGenerator, upgraded and rebased #21800
Conversation
04e81b7
to
816b8b5
Compare
Job Documentation on bac2360 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on bac2360 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
Job End user mac on 816b8b5 : invalidated by @milljm Old packages were pulled by mistake |
Looks like this might be an real exodiff on Mac. I've been afraid of this potentially happening for a while, trying to avoid cases where there are multiple valid Delaunay triangulations of a test case, but looks like something of that sort caught up with me. |
framework/doc/content/source/meshgenerators/Poly2TriMeshGenerator.md
Outdated
Show resolved
Hide resolved
framework/doc/content/source/meshgenerators/Poly2TriMeshGenerator.md
Outdated
Show resolved
Hide resolved
test/tests/meshgenerators/poly2tri_mesh_generator/poly2tri_from_1d_sbdids.i
Outdated
Show resolved
Hide resolved
test/tests/meshgenerators/poly2tri_mesh_generator/poly2tri_from_1d_sbdids.i
Outdated
Show resolved
Hide resolved
7f0ab39
to
1958954
Compare
lemme know when/if you want my eyes on this |
I'd appreciate that, thanks! I committed the responses to Logan's concerns last week, but he's a bit busy lately, and in any case the more eyes the better. |
... and apparently it needs more attention from my eyes too. I've now discovered that, just because a feature has test coverage for bugs in libMesh and has an interface here doesn't mean the interface doesn't have bugs. I'll fix that, and scan the code coverage misses for anything else important I'm not hitting. |
test/tests/meshgenerators/poly2tri_mesh_generator/poly2tri_nested.i
Outdated
Show resolved
Hide resolved
Right! If you know anyone who can fix it, just about every number in https://mooseframework.inl.gov/source/index.html gets rendered with the same bug. In this case, though, for reasons discussed in the previous PR, |
test/tests/meshgenerators/poly2tri_mesh_generator/poly2tri_with_holes.i
Outdated
Show resolved
Hide resolved
test/tests/meshgenerators/poly2tri_mesh_generator/poly2tri_nested.i
Outdated
Show resolved
Hide resolved
So, @roystgnr this is indeed doing triangulation? I am very excited about this capability. What triangulator is this using? |
Poly2Tri does the initial triangulation; all the triangulation refinement code is my own ... and the result gets handed back to Poly2Tri before the user sees it, just in case I've made a mistake and come up with something non-Delaunay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Also please move the images to large_media
This avoids libMesh misidentifying a conflict when desired_area_func is set.
We should probably support stitching in 1D, but that'd be a major change.
Poly2Tri was flexible enough to handle either ordering, but the libMesh hole boundary refinement code wasn't.
2ea2ba3
to
ca4e811
Compare
Job Precheck on ca4e811 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
Thanks to Logan for catching these.
Thanks to Yaqi for prompting this
Just to make sure something screams if that option is ever mistakenly removed.
81519ed
to
6d02be4
Compare
Didn't realize I'd missed this one until I was double-checking Logan's suggestions before resolving them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason
This is now both sufficient and necessary to close #20192; Rocstar's stuff isn't going to be integrated in the near term, for sure.
Design
PolyLineMeshGenerator gives us the ability to specify arbitrary boundary loops, then Poly2TriMeshGenerator lets us triangulate boundaries specified by those loops (or by the boundary of some input 2D Mesh), with optional holes (that can either be left unfilled or can be stitched to the mesh defining them) defined by other input meshes, with various options for mesh and/or boundary refinement and for mesh smoothing.
Impact
This adds two new mesh generators, along with tests and documentation.
Along the way I added input file support for vector parameters, and fixed a typo in the doc I was using as an example for how to write MOOSE docs. DistributedMesh support for StitchedMeshGenerator is also in here.
This obsoletes #21303. The main changes since then are in the checklist there.