New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poly2TriMeshGenerator, upgraded and rebased #21800
Poly2TriMeshGenerator, upgraded and rebased #21800
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1828667 - Browse repository at this point
Copy the full SHA 1828667View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54861f9 - Browse repository at this point
Copy the full SHA 54861f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07cc9e0 - Browse repository at this point
Copy the full SHA 07cc9e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a626250 - Browse repository at this point
Copy the full SHA a626250View commit details -
Configuration menu - View commit details
-
Copy full SHA for c32522f - Browse repository at this point
Copy the full SHA c32522fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c8486d - Browse repository at this point
Copy the full SHA 0c8486dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38baee7 - Browse repository at this point
Copy the full SHA 38baee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b6515c - Browse repository at this point
Copy the full SHA 2b6515cView commit details -
Configuration menu - View commit details
-
Copy full SHA for db38ffe - Browse repository at this point
Copy the full SHA db38ffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ef9509 - Browse repository at this point
Copy the full SHA 8ef9509View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c311e - Browse repository at this point
Copy the full SHA 66c311eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8baf371 - Browse repository at this point
Copy the full SHA 8baf371View commit details -
Configuration menu - View commit details
-
Copy full SHA for 543e81c - Browse repository at this point
Copy the full SHA 543e81cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 457d907 - Browse repository at this point
Copy the full SHA 457d907View commit details -
Configuration menu - View commit details
-
Copy full SHA for f436c39 - Browse repository at this point
Copy the full SHA f436c39View commit details -
Poly2TriMeshGenerator Laplacian smoothing option
We need something better here but this is what was already in libMesh and it ought to be good enough for now.
Configuration menu - View commit details
-
Copy full SHA for c2a4e9d - Browse repository at this point
Copy the full SHA c2a4e9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0324720 - Browse repository at this point
Copy the full SHA 0324720View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ff2248 - Browse repository at this point
Copy the full SHA 9ff2248View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9469eb6 - Browse repository at this point
Copy the full SHA 9469eb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c4b391 - Browse repository at this point
Copy the full SHA 5c4b391View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54efbd7 - Browse repository at this point
Copy the full SHA 54efbd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b36ae57 - Browse repository at this point
Copy the full SHA b36ae57View commit details -
Only run Poly2Tri tests on ReplicatedMesh for now
We'll need to wait for a libMesh update with a fix there before we have DistributedMesh triangulation properly working.
Configuration menu - View commit details
-
Copy full SHA for b4b0f8b - Browse repository at this point
Copy the full SHA b4b0f8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a68f2ef - Browse repository at this point
Copy the full SHA a68f2efView commit details -
We can't do this with our unique_ptr input mesh because of the move assignent / dynamic recasting that happens later, but for everything else we set it from the input file and don't touch it again.
Configuration menu - View commit details
-
Copy full SHA for c420ac7 - Browse repository at this point
Copy the full SHA c420ac7View commit details -
_nebp -> _num_edges_between_points
Add a bit more readability, at Logan's suggestion
Configuration menu - View commit details
-
Copy full SHA for 977207c - Browse repository at this point
Copy the full SHA 977207cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 582d8b0 - Browse repository at this point
Copy the full SHA 582d8b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0d2343 - Browse repository at this point
Copy the full SHA c0d2343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d5673d - Browse repository at this point
Copy the full SHA 5d5673dView commit details -
Comment new mesh generator member variables
These mostly map 1-to-1 to parameters, but this way we get the descriptions into Doxygen too.
Configuration menu - View commit details
-
Copy full SHA for 33bf703 - Browse repository at this point
Copy the full SHA 33bf703View commit details -
Refactor new mesh generator tests files
Also link to the triangulator issue
Configuration menu - View commit details
-
Copy full SHA for 0a4ddff - Browse repository at this point
Copy the full SHA 0a4ddffView commit details -
We were getting this indirectly in Unity builds but we need it directly for non-Unity.
Configuration menu - View commit details
-
Copy full SHA for 36fa59a - Browse repository at this point
Copy the full SHA 36fa59aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd5e2d5 - Browse repository at this point
Copy the full SHA dd5e2d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 585cb6f - Browse repository at this point
Copy the full SHA 585cb6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32ea428 - Browse repository at this point
Copy the full SHA 32ea428View commit details -
Remove interpolate_holes param
This is a bit redundant (if we have a polyline hole we can easily interpolate while generating it, and if we have a 2D mesh hole we probably don't want to interpolate it and if we do we can refine it) and the implementation was going to be a bit more hassle than I thought.
Configuration menu - View commit details
-
Copy full SHA for c1a1b1e - Browse repository at this point
Copy the full SHA c1a1b1eView commit details -
paramError if we allow refining stitched hole bdys
This should catch any potential mismatch when stitching.
Configuration menu - View commit details
-
Copy full SHA for 31a1258 - Browse repository at this point
Copy the full SHA 31a1258View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb45d6e - Browse repository at this point
Copy the full SHA bb45d6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 668d0d5 - Browse repository at this point
Copy the full SHA 668d0d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdf871c - Browse repository at this point
Copy the full SHA bdf871cView commit details -
Serialize in Poly2TriMeshGenerator where necessary
With this plus some libMesh fixes I'm seeing tests pass on DistributedMesh too.
Configuration menu - View commit details
-
Copy full SHA for eec3c80 - Browse repository at this point
Copy the full SHA eec3c80View commit details -
Omit parallel_type = replicated on poly2tri tests
With the fixes here and in libMesh we can run with DistributedMesh too now.
Configuration menu - View commit details
-
Copy full SHA for 424ce3a - Browse repository at this point
Copy the full SHA 424ce3aView commit details -
Support DistributedMesh in StitchedMeshGenerator
libMesh added this support a while ago but I forgot to update MOOSE to match.
Configuration menu - View commit details
-
Copy full SHA for ae3f69a - Browse repository at this point
Copy the full SHA ae3f69aView commit details -
add_nodes_per_boundary_segment fixed in libMesh
So we can either regold the Exodus files or we can change the input files; let's do the latter.
Configuration menu - View commit details
-
Copy full SHA for 408ed83 - Browse repository at this point
Copy the full SHA 408ed83View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1effba - Browse repository at this point
Copy the full SHA a1effbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c83826c - Browse repository at this point
Copy the full SHA c83826cView commit details -
Use block_id and block_name in stitching test
We seem to have some trouble with exodiff not caring if our block ids or block names change, which does make it tricky to test a feature for changing those ... but the Exodus limitation on multiple element types in the same block is enough that this test still gives us *some* coverage; if the triangle subdomain_id()s aren't all changed to *something* then we find ourselves unable to write them.
Configuration menu - View commit details
-
Copy full SHA for 8bc41f5 - Browse repository at this point
Copy the full SHA 8bc41f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c86ad52 - Browse repository at this point
Copy the full SHA c86ad52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88761f4 - Browse repository at this point
Copy the full SHA 88761f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for be0337f - Browse repository at this point
Copy the full SHA be0337fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64a62fa - Browse repository at this point
Copy the full SHA 64a62faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39d779d - Browse repository at this point
Copy the full SHA 39d779dView commit details -
Use less refinement in regression test
Guaranteeing that we refine to the same final mesh while doing floating-point comparisons in different compiled binaries is tricky. Let's back off for now so we can pass the same tests on Mac and Linux.
Configuration menu - View commit details
-
Copy full SHA for 30cee79 - Browse repository at this point
Copy the full SHA 30cee79View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4fc5b4 - Browse repository at this point
Copy the full SHA c4fc5b4View commit details -
Clean Output blocks, ./ syntax out of new inputs
The ./ is no longer necessary, and Output is not necessary for tests that always get run --mesh-only
Configuration menu - View commit details
-
Copy full SHA for 8fc26e5 - Browse repository at this point
Copy the full SHA 8fc26e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee33320 - Browse repository at this point
Copy the full SHA ee33320View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd96cd3 - Browse repository at this point
Copy the full SHA bd96cd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c016d82 - Browse repository at this point
Copy the full SHA c016d82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2036c92 - Browse repository at this point
Copy the full SHA 2036c92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99938c2 - Browse repository at this point
Copy the full SHA 99938c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 143061d - Browse repository at this point
Copy the full SHA 143061dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8310207 - Browse repository at this point
Copy the full SHA 8310207View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b7782e - Browse repository at this point
Copy the full SHA 7b7782eView commit details -
This avoids libMesh misidentifying a conflict when desired_area_func is set.
Configuration menu - View commit details
-
Copy full SHA for 2fde739 - Browse repository at this point
Copy the full SHA 2fde739View commit details -
Report error if stitched hole meshes are non-2D
We should probably support stitching in 1D, but that'd be a major change.
Configuration menu - View commit details
-
Copy full SHA for 2dd9c6f - Browse repository at this point
Copy the full SHA 2dd9c6fView commit details -
Match libMesh fix to MeshedHole point ordering
Poly2Tri was flexible enough to handle either ordering, but the libMesh hole boundary refinement code wasn't.
Configuration menu - View commit details
-
Copy full SHA for dbd8358 - Browse repository at this point
Copy the full SHA dbd8358View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca4e811 - Browse repository at this point
Copy the full SHA ca4e811View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ba278f - Browse repository at this point
Copy the full SHA 8ba278fView commit details -
Fix local variable names, constness, avoid copy
Thanks to Logan for catching these.
Configuration menu - View commit details
-
Copy full SHA for 8683ed2 - Browse repository at this point
Copy the full SHA 8683ed2View commit details -
Test for output hole_boundaries names
Thanks to Yaqi for prompting this
Configuration menu - View commit details
-
Copy full SHA for f4e6b3e - Browse repository at this point
Copy the full SHA f4e6b3eView commit details -
Throw verify_holes=false in a test
Just to make sure something screams if that option is ever mistakenly removed.
Configuration menu - View commit details
-
Copy full SHA for b6fc9f6 - Browse repository at this point
Copy the full SHA b6fc9f6View commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6d02be4 - Browse repository at this point
Copy the full SHA 6d02be4View commit details -
Didn't realize I'd missed this one until I was double-checking Logan's suggestions before resolving them.
Configuration menu - View commit details
-
Copy full SHA for bac2360 - Browse repository at this point
Copy the full SHA bac2360View commit details