Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poly2TriMeshGenerator, upgraded and rebased #21800

Merged
merged 73 commits into from Sep 16, 2022

Commits on Sep 13, 2022

  1. Added PolyLineMeshGenerator

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    1828667 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54861f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07cc9e0 View commit details
    Browse the repository at this point in the history
  4. Added Poly2TriMeshGenerator

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a626250 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c32522f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0c8486d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    38baee7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2b6515c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    db38ffe View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8ef9509 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    66c311e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8baf371 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    543e81c View commit details
    Browse the repository at this point in the history
  14. Fix class description typo

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    457d907 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f436c39 View commit details
    Browse the repository at this point in the history
  16. Poly2TriMeshGenerator Laplacian smoothing option

    We need something better here but this is what was already in libMesh
    and it ought to be good enough for now.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c2a4e9d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0324720 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    9ff2248 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9469eb6 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    5c4b391 View commit details
    Browse the repository at this point in the history
  21. Remove trailing whitespace

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    54efbd7 View commit details
    Browse the repository at this point in the history
  22. clang-format changes

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b36ae57 View commit details
    Browse the repository at this point in the history
  23. Only run Poly2Tri tests on ReplicatedMesh for now

    We'll need to wait for a libMesh update with a fix there before we have
    DistributedMesh triangulation properly working.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b4b0f8b View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    a68f2ef View commit details
    Browse the repository at this point in the history
  25. Mark const members as const

    We can't do this with our unique_ptr input mesh because of the move
    assignent / dynamic recasting that happens later, but for everything
    else we set it from the input file and don't touch it again.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c420ac7 View commit details
    Browse the repository at this point in the history
  26. _nebp -> _num_edges_between_points

    Add a bit more readability, at Logan's suggestion
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    977207c View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    582d8b0 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    c0d2343 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    5d5673d View commit details
    Browse the repository at this point in the history
  30. Comment new mesh generator member variables

    These mostly map 1-to-1 to parameters, but this way we get the
    descriptions into Doxygen too.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    33bf703 View commit details
    Browse the repository at this point in the history
  31. Refactor new mesh generator tests files

    Also link to the triangulator issue
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    0a4ddff View commit details
    Browse the repository at this point in the history
  32. Add MooseMeshUtils.h include

    We were getting this indirectly in Unity builds but we need it directly
    for non-Unity.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    36fa59a View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    dd5e2d5 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    585cb6f View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    32ea428 View commit details
    Browse the repository at this point in the history
  36. Remove interpolate_holes param

    This is a bit redundant (if we have a polyline hole we can easily
    interpolate while generating it, and if we have a 2D mesh hole we
    probably don't want to interpolate it and if we do we can refine it) and
    the implementation was going to be a bit more hassle than I thought.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c1a1b1e View commit details
    Browse the repository at this point in the history
  37. paramError if we allow refining stitched hole bdys

    This should catch any potential mismatch when stitching.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    31a1258 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    bb45d6e View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    668d0d5 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    bdf871c View commit details
    Browse the repository at this point in the history
  41. Serialize in Poly2TriMeshGenerator where necessary

    With this plus some libMesh fixes I'm seeing tests pass on
    DistributedMesh too.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    eec3c80 View commit details
    Browse the repository at this point in the history
  42. Omit parallel_type = replicated on poly2tri tests

    With the fixes here and in libMesh we can run with DistributedMesh too
    now.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    424ce3a View commit details
    Browse the repository at this point in the history
  43. Support DistributedMesh in StitchedMeshGenerator

    libMesh added this support a while ago but I forgot to update MOOSE to
    match.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    ae3f69a View commit details
    Browse the repository at this point in the history
  44. add_nodes_per_boundary_segment fixed in libMesh

    So we can either regold the Exodus files or we can change the input
    files; let's do the latter.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    408ed83 View commit details
    Browse the repository at this point in the history
  45. Error-reporting tests

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a1effba View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    c83826c View commit details
    Browse the repository at this point in the history
  47. Use block_id and block_name in stitching test

    We seem to have some trouble with exodiff not caring if our block ids
    or block names change, which does make it tricky to test a feature for
    changing those ... but the Exodus limitation on multiple element types
    in the same block is enough that this test still gives us *some*
    coverage; if the triangle subdomain_id()s aren't all changed to
    *something* then we find ourselves unable to write them.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8bc41f5 View commit details
    Browse the repository at this point in the history
  48. Rename block -> output_subdomain

    This is a longer but clearer
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c86ad52 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    88761f4 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    be0337f View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    64a62fa View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    39d779d View commit details
    Browse the repository at this point in the history
  53. Use less refinement in regression test

    Guaranteeing that we refine to the same final mesh while doing
    floating-point comparisons in different compiled binaries is tricky.
    Let's back off for now so we can pass the same tests on Mac and Linux.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    30cee79 View commit details
    Browse the repository at this point in the history
  54. Use links in docs

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c4fc5b4 View commit details
    Browse the repository at this point in the history
  55. Clean Output blocks, ./ syntax out of new inputs

    The ./ is no longer necessary, and Output is not necessary for tests
    that always get run --mesh-only
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8fc26e5 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    ee33320 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    bd96cd3 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    c016d82 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    2036c92 View commit details
    Browse the repository at this point in the history
  60. Fix swapped name/detail

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    99938c2 View commit details
    Browse the repository at this point in the history
  61. Remove whitespace

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    143061d View commit details
    Browse the repository at this point in the history
  62. Move images to large_media

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8310207 View commit details
    Browse the repository at this point in the history
  63. Get figures from large_media

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    7b7782e View commit details
    Browse the repository at this point in the history
  64. Better desired_area handling

    This avoids libMesh misidentifying a conflict when desired_area_func is
    set.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2fde739 View commit details
    Browse the repository at this point in the history
  65. Report error if stitched hole meshes are non-2D

    We should probably support stitching in 1D, but that'd be a major
    change.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2dd9c6f View commit details
    Browse the repository at this point in the history
  66. Match libMesh fix to MeshedHole point ordering

    Poly2Tri was flexible enough to handle either ordering, but the libMesh
    hole boundary refinement code wasn't.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    dbd8358 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    ca4e811 View commit details
    Browse the repository at this point in the history
  68. clang-format fixes

    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8ba278f View commit details
    Browse the repository at this point in the history
  69. Fix local variable names, constness, avoid copy

    Thanks to Logan for catching these.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8683ed2 View commit details
    Browse the repository at this point in the history
  70. Test for output hole_boundaries names

    Thanks to Yaqi for prompting this
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f4e6b3e View commit details
    Browse the repository at this point in the history
  71. Throw verify_holes=false in a test

    Just to make sure something screams if that option is ever mistakenly
    removed.
    roystgnr committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b6fc9f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Configuration menu
    Copy the full SHA
    6d02be4 View commit details
    Browse the repository at this point in the history
  2. Fix unnecessary vector copy

    Didn't realize I'd missed this one until I was double-checking Logan's
    suggestions before resolving them.
    roystgnr committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    bac2360 View commit details
    Browse the repository at this point in the history