-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thermochimica submodule and coupling code #22712
Conversation
7a17675
to
89eae15
Compare
Some comments
|
cc6c1a9
to
fe96d22
Compare
Is Relap-7 currently broken? |
Note to future self: we could support threaded execution and multiple Thermochimica instances with a wrapper that uses |
Job Documentation on c9a7b7d wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on c9a7b7d wanted to post the following: Framework coverage
Modules coverageChemical reactions
Full coverage reportsReports
This comment will be updated on new commits. |
modules/chemical_reactions/include/auxkernels/ThermochimicaAux.h
Outdated
Show resolved
Hide resolved
In most cases we don't |
Edit: I opened ORNL-CEES/thermochimica#109 for this purpose |
Job App documentation on fe96d22 : invalidated by @joshuahansel RELAP-7 fixed |
fe96d22
to
2534e41
Compare
Ugh, in this version of the PR I forgot to transfer the doc files. I'll have to fix that when I'm back next week. |
All jobs on 2534e41 : invalidated by @loganharbour Re-run now that we checkout the submodule |
Job Test timings on c9a7b7d wanted to post the following: View timings here This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments on Saline PR on the Makefile
2534e41
to
0757c24
Compare
0a99b56
to
9eac92b
Compare
Everything passed and is green (if you click through to Civet). Looks like the status update on Github is just not working right. |
It seems. i think a few comments did not get addressed too |
de440da
to
8ecc9a7
Compare
8ecc9a7
to
649039a
Compare
modules/chemical_reactions/doc/content/source/actions/ChemicalCompositionAction.md
Outdated
Show resolved
Hide resolved
649039a
to
dd6a9f3
Compare
c91c752
to
2c67a7e
Compare
65cc1a8
to
0ecb5fa
Compare
0ecb5fa
to
c9a7b7d
Compare
Closes #22711