Helical extrusion feature during extrusion around an axis #25089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
force-pushed
the
PR_daniel_helical
branch
from
6f5aa31
to
f9275f5
Compare
|
Job Documentation on dfa374e wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
force-pushed
the
PR_daniel_helical
branch
2 times, most recently
from
85302f9
to
3395016
Compare
|
Job Coverage on dfa374e wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
GiudGiud
force-pushed
the
PR_daniel_helical
branch
from
3395016
to
dbb4207
Compare
and trying to get their shape corrected refs idaholab#23972
Add a test for helicoidal extrusion refs idaholab#25486
GiudGiud
force-pushed
the
PR_daniel_helical
branch
from
27a5467
to
7ab3a06
Compare
lindsayad
requested changes
Sep 19, 2023
|
Job Precheck on 348df45 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
GiudGiud
force-pushed
the
PR_daniel_helical
branch
2 times, most recently
from
541b987
to
7d7d625
Compare
lindsayad
previously approved these changes
Sep 19, 2023
more constness cache node lists Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
GiudGiud
force-pushed
the
PR_daniel_helical
branch
from
7d7d625
to
dfa374e
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to make helicoidal fuel like the Lightbridge fuel
One thing to note is that we could also just parametrize everything with "s" being a curve absciss,
then use parsed functions for x(s), y(s), z(s). This would cover regular extrusion, helical, and many more.
Fun (complex/parsed) extrusion like projects I could see:
The additional changes are things I ended up needing in the project to get the geometry to mesh properly and be able to correct the volume.
closes #25486