Add optimized linear system assembly for finite volume computations #25745

grmnptr · 2023-10-13T21:37:10Z

Refs #25722

Major issues to fix:

Cleaning up MooseVariable inheritance/interfaces for linear variables.
Improve test coverage.
Unify solve systems

moosebuild · 2024-01-26T03:43:37Z

Job Documentation on adbef30 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2024-01-30T01:10:11Z

Job Coverage on adbef30 wanted to post the following:

Framework coverage

	e235a2	#25745 adbef3
	Total	Total	+/-	New
Rate	85.29%	85.14%	-0.15%	77.87%
Hits	101437	102535	+1098	1626
Misses	17500	17902	+402	462

Diff coverage report

Full coverage report

Modules coverage

Heat transfer

	e235a2	#25745 adbef3
	Total	Total	+/-	New
Rate	88.46%	88.46%	-	100.00%
Hits	4055	4055	-	1
Misses	529	529	-	0

Diff coverage report

Full coverage report

Navier stokes

	e235a2	#25745 adbef3
	Total	Total	+/-	New
Rate	84.78%	84.78%	-	100.00%
Hits	14596	14596	-	1
Misses	2620	2620	-	0

Diff coverage report

Full coverage report

Solid mechanics

	e235a2	#25745 adbef3
	Total	Total	+/-	New
Rate	84.78%	84.78%	-	100.00%
Hits	27109	27109	-	2
Misses	4868	4868	-	0

Diff coverage report

Full coverage report

Thermal hydraulics

	e235a2	#25745 adbef3
	Total	Total	+/-	New
Rate	89.11%	89.10%	-0.00%	100.00%
Hits	13970	13968	-2	2
Misses	1708	1708	-	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

framework new line coverage rate 77.87% is less than the suggested 90.0%

This comment will be updated on new commits.

lindsayad

Just through the first two files. Very nice design page. I will continue reviewing tomorrow

framework/doc/content/finite_volumes/linear_fv_design.md

lindsayad

beginning to glance through the code, I haven't run into big concerns yet. A couple thoughts I do have:

There seems like a fair amount of dead, unused code in LinearSystem. Can we remove some of it or test some of it or both?
I noticed that the majority of uncovered code is from overrides of methods in MooseVariableField that simply aren't relevant to your new variable. Would it make sense to create another class, perhaps MooseVariableNonlinearField or something like that, that sits in between MooseVariableField and MooseVariableFE/FV that has all those pure virtuals that are irrelevant to your class?

framework/include/systems/LinearSystem.h

framework/src/base/MooseApp.C

lindsayad · 2024-02-01T19:46:33Z

Would it make sense to create another class, perhaps MooseVariableNonlinearField or something like that, that sits in between MooseVariableField and MooseVariableFE/FV that has all those pure virtuals that are irrelevant to your class?

Another idea would be to inherit directly from MooseVariableFieldBase. I haven't investigated either idea thoroughly. I know you rely on functors, but you also don't support automatic differentiation, so perhaps inheriting from FunctorBase<Real> would actually be a good thing

grmnptr · 2024-02-01T19:49:28Z

Well, I would like to keep using variable-based interfaces (throught the FE problem and variablke interface) but I will definitely think about how to make this part cleaner! Yeah FunctorBase<ADReal> right now is not ideal. Would it add additional costs if the derivative containers are always empty?

lindsayad · 2024-02-01T20:13:34Z

Well, I would like to keep using variable-based interfaces (throught the FE problem and variablke interface) but I will definitely think about how to make this part cleaner!

You may need to make new interfaces. But I think a design in which we don't have all these erroring overrides would lead to a lot of good cleanup. It would likely make it impossible to use a linear variable in a place where only a nonlinear variable will work and visa versa

…ab#25722)

This member can be used in downstream objects which use functor interfaces and hence don't care why type of field variable the variable is

…lab#25722)

GiudGiud assigned grmnptr Oct 17, 2023

grmnptr force-pushed the linear-system-25722 branch 2 times, most recently from 1cd22b0 to 0405e4b Compare October 19, 2023 01:29

grmnptr force-pushed the linear-system-25722 branch 2 times, most recently from 743e1a9 to a498165 Compare November 8, 2023 21:10

grmnptr force-pushed the linear-system-25722 branch from e9cbe08 to 117deda Compare December 6, 2023 00:33

grmnptr force-pushed the linear-system-25722 branch from dce8a94 to fb0e041 Compare January 26, 2024 01:57

grmnptr changed the title ~~[WIP] Add optimized linear system assembly~~ Add optimized linear system assembly Jan 26, 2024

grmnptr force-pushed the linear-system-25722 branch from fb0e041 to cc6e2fe Compare January 26, 2024 02:02

idaholab deleted a comment from moosebuild Jan 26, 2024

grmnptr force-pushed the linear-system-25722 branch 5 times, most recently from f815da4 to 6c962f1 Compare January 29, 2024 22:49

grmnptr force-pushed the linear-system-25722 branch from ccc1528 to 545df81 Compare January 30, 2024 02:32

idaholab deleted a comment from moosebuild Jan 30, 2024

grmnptr marked this pull request as ready for review January 30, 2024 20:03

grmnptr requested review from lindsayad, GiudGiud and roystgnr as code owners January 30, 2024 20:03

grmnptr changed the title ~~Add optimized linear system assembly~~ Add optimized linear system assembly for finite volume computations Jan 30, 2024

lindsayad requested changes Feb 1, 2024

View reviewed changes

framework/include/systems/LinearSystem.h Outdated Show resolved Hide resolved

framework/include/systems/LinearSystem.h Outdated Show resolved Hide resolved

lindsayad reviewed Feb 1, 2024

View reviewed changes

framework/src/base/MooseApp.C Outdated Show resolved Hide resolved

grmnptr and others added 27 commits March 26, 2024 11:58

Move array/vector/standard definitions to MooseVariableField. (idahol…

13e6986

…ab#25722)

Add linear system doc page. (idaholab#25722)

42eea25

Move relationship manager routines to new interface. (idaholab#25722)

77b5256

Add execution log printing. (idaholab#25722)

4500ed6

Add more error coverage and multiapp test. (idaholab#25722)

9aa38ff

Add test for block-restricted physics. (idaholab#25722)

a637e8d

Mark erroring overrides with non-void return type as [[noreturn]]

286cb82

Fix module tests. (idaholab#25722)

d31ff02

Fix threading issues. (idaholab#25722)

a9815f4

Create a _field_variable member in MooseVariableInterface

dcc3832

This member can be used in downstream objects which use functor interfaces and hence don't care why type of field variable the variable is

Reinit assembly data on faces associated with linear systems

65914b7

Testing postprocessing abilities of linear fv vars

8ea535d

Materials -> FunctorMaterials to avoid deprecation warning

38179ee

Get gradients correct for postprocessing and in parallel

8749550

Do 1st-order approx for Green-Gauss for external faces with natural bc

629e074

No need to update; libmesh already does it

40c91e9

No need to close solution; libmesh asserts it's already closed

cf206ab

Move gradient stroage to the system. (idaholab#25722)

5441b6b

Fix optimization tests. (idaholab#25772)

bc5a2fe

Move more vector operations out of the threaded loop. (idaholab#25722)

b22f8f8

Disable threading with MooseLinearVariableFV. (idaholab#25722)

2946617

Add smaller changes from code review. (idaholab#25722)

afdc21c

Make boundary conditions more specific to advection diffusion. (idaho…

bec45d3

…lab#25722)

Add stopSolve to LinearSystem. (idaholab#25722)

d4ddc58

Fix sweep errors. (idaholab#25722)

404011f

Polish documentation, switch to static cast. (idaholab#25722)

03741ae

Add missing virtual functions after rebase. (idaholab#25722)

adbef30

grmnptr force-pushed the linear-system-25722 branch from 00381b6 to adbef30 Compare March 26, 2024 18:12

lindsayad approved these changes Mar 27, 2024

View reviewed changes

grmnptr merged commit 80c0cd2 into idaholab:next Mar 27, 2024
60 of 64 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add optimized linear system assembly for finite volume computations #25745

Add optimized linear system assembly for finite volume computations #25745

grmnptr commented Oct 13, 2023 •

edited

Loading

moosebuild commented Jan 26, 2024 •

edited

Loading

moosebuild commented Jan 30, 2024 •

edited

Loading

lindsayad left a comment

lindsayad left a comment

lindsayad commented Feb 1, 2024

grmnptr commented Feb 1, 2024 •

edited

Loading

lindsayad commented Feb 1, 2024

Add optimized linear system assembly for finite volume computations #25745

Add optimized linear system assembly for finite volume computations #25745

Conversation

grmnptr commented Oct 13, 2023 • edited Loading

moosebuild commented Jan 26, 2024 • edited Loading

moosebuild commented Jan 30, 2024 • edited Loading

Framework coverage

Modules coverage

Heat transfer

Navier stokes

Solid mechanics

Thermal hydraulics

Full coverage reports

Warnings

lindsayad left a comment

Choose a reason for hiding this comment

lindsayad left a comment

Choose a reason for hiding this comment

lindsayad commented Feb 1, 2024

grmnptr commented Feb 1, 2024 • edited Loading

lindsayad commented Feb 1, 2024

grmnptr commented Oct 13, 2023 •

edited

Loading

moosebuild commented Jan 26, 2024 •

edited

Loading

moosebuild commented Jan 30, 2024 •

edited

Loading

grmnptr commented Feb 1, 2024 •

edited

Loading