-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nD Rosenbrock function for testing surrogate models in STM #27475
Conversation
Job Documentation on f96f646 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on f96f646 wanted to post the following: Framework coverageCoverage did not change Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
Job No optional on f96f646 : invalidated by @grmnptr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great contribution! Could you add a test for both classify and no classify cases, please?
InputParameters params = GeneralVectorPostprocessor::validParams(); | ||
params.addRequiredParam<SamplerName>( | ||
"sampler", "The Sampler object to use to perform g-function evaluations."); | ||
params.addParam<bool>("classify", false, "Flag to turn return binary values."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
params.addParam<bool>("classify", false, "Flag to turn return binary values."); | |
params.addParam<bool>("classify", false, "Flag to return binary values."); |
_classify(getParam<bool>("classify")), | ||
_limiting_value(getParam<Real>("limiting_value")), | ||
_values(declareVector("g_values")) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a param error here if limiting_value
is defined by the user while _classify
is false
.
|
||
#include "GeneralVectorPostprocessor.h" | ||
|
||
/* SOBOL test function, see Slaughter, Eq. 5.51 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* SOBOL test function, see Slaughter, Eq. 5.51 */ | |
/* nD Rosenbrock function, see [some reference here or describe the expression] */ |
const bool & _classify; | ||
const Real & _limiting_value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const bool & _classify; | |
const Real & _limiting_value; | |
const bool _classify; | |
const Real _limiting_value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you need these to be controllable.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Motivation
An nD Rosenbrock function is a complex analytical function involving heavy tails and non-convex structures. It's a cheap and effective function to test surrogate models in the STM.
Design
An
nDRosenbrock
test vpp will be created in the STM.Impact
No expected impact to existing objects.
closes #27469