Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nD Rosenbrock function for testing surrogate models in STM #27475

Closed
wants to merge 1 commit into from

Conversation

somu15
Copy link
Contributor

@somu15 somu15 commented Apr 25, 2024

Motivation

An nD Rosenbrock function is a complex analytical function involving heavy tails and non-convex structures. It's a cheap and effective function to test surrogate models in the STM.

Design

An nDRosenbrock test vpp will be created in the STM.

Impact

No expected impact to existing objects.

closes #27469

@moosebuild
Copy link
Contributor

Job Documentation on f96f646 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage on f96f646 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job No optional on f96f646 : invalidated by @grmnptr

Copy link
Contributor

@grmnptr grmnptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution! Could you add a test for both classify and no classify cases, please?

InputParameters params = GeneralVectorPostprocessor::validParams();
params.addRequiredParam<SamplerName>(
"sampler", "The Sampler object to use to perform g-function evaluations.");
params.addParam<bool>("classify", false, "Flag to turn return binary values.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
params.addParam<bool>("classify", false, "Flag to turn return binary values.");
params.addParam<bool>("classify", false, "Flag to return binary values.");

_classify(getParam<bool>("classify")),
_limiting_value(getParam<Real>("limiting_value")),
_values(declareVector("g_values"))
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a param error here if limiting_value is defined by the user while _classify is false.


#include "GeneralVectorPostprocessor.h"

/* SOBOL test function, see Slaughter, Eq. 5.51 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* SOBOL test function, see Slaughter, Eq. 5.51 */
/* nD Rosenbrock function, see [some reference here or describe the expression] */

Comment on lines +25 to +26
const bool & _classify;
const Real & _limiting_value;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const bool & _classify;
const Real & _limiting_value;
const bool _classify;
const Real _limiting_value;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you need these to be controllable.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale PRs that have reached or exceeded 90 days with no activity label Aug 28, 2024
@github-actions github-actions bot closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Failed but allowed stale PRs that have reached or exceeded 90 days with no activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nD Rosenbrock function for testing surrogate models in STM
3 participants