Rename a few objects based on issues created

[GiudGiud]

refs #26615 #22055 #26755

[moosebuild]

Job Documentation on 4107b2e wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage on 4107b2e wanted to post the following:

Framework coverage

	ca913d	#27908 4107b2
	Total	Total	+/-	New
Rate	85.08%	85.08%	-	96.72%
Hits	104117	104117	-	236
Misses	18265	18265	-	8

Diff coverage report

Full coverage report

Modules coverage

Rdg

	ca913d	#27908 4107b2
	Total	Total	+/-	New
Rate	63.32%	63.32%	-	95.65%
Hits	454	454	-	22
Misses	263	263	-	1

Diff coverage report

Full coverage report

Solid mechanics

	ca913d	#27908 4107b2
	Total	Total	+/-	New
Rate	84.86%	84.86%	-	90.59%
Hits	27679	27679	-	77
Misses	4938	4938	-	8

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[GiudGiud]

Should be ready for review now.

[joshuahansel]

The renames seem good other than maybe ExamplePatchMeshGenerator - that one does sound like it needs to be moved to test (as suggested in the issue) if it has a name like that. And I would usually do "Test" instead of "Example", but this is an optional change.

[GiudGiud]

It's heavily relied on in Bison so we cant move it to test.
We could move it to Bison

The rename solves my problem with it. (which is that it pretends to be a grouper/patcher of MGs)

[joshuahansel]

It's relied upon in Bison for actual usage or just testing? If actual usage, then I guess "Example" is inappropriate. If just testing, we just need to have Bison add moose test objects in its test executable, right?

[GiudGiud]

Just testing. That's not really Makefile work I would like to do.
The renaming is necessary even if we move it to test and do the Makefile work btw

[joshuahansel]

Makefile work? I thought would just be a one-liner in BisonTestApp. For example, in SockeyeTestApp::registerAll() we do

ThermalHydraulicsTestApp::registerAll(f, af, s, true);

to get THM test objects. If that's not the case, then nevermind.

[joshuahansel]

The suggested move of ExamplePatchMeshGenerator to test/ is an optional follow-up change (after Bison changes).

[GiudGiud]

Thanks!
Ah yes it could be just that. That would be fine as long as Bison folks are fine with it