Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and test MechanicalContactConstraint ref #2816 #3020

Merged
merged 1 commit into from
Apr 29, 2014

Conversation

bwspenc
Copy link
Contributor

@bwspenc bwspenc commented Apr 28, 2014

MechanicalContactConstraint is a general class for doing the full
set of contact formulations and friction models currently supported
by the DiracKernel-based mechanical contact system.

I've added a few 2D tests of this capability with this commit. We're
working on a more comprehensive contact test suite.

@moosebuild
Copy link
Contributor

Results of testing 88ff79a using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1687

@moosebuild
Copy link
Contributor

Results of testing 88ff79a using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1688

const Real _penalty;
const Real _friction_coefficient;
const Real _tension_release;
bool _updateContactSet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't follow the naming convention - and looks out of place since everything else does ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll fix it.

@bwspenc
Copy link
Contributor Author

bwspenc commented Apr 28, 2014

I modified my nasty looking code. Countless curly braces have been conserved for future generations.

@moosebuild
Copy link
Contributor

Results of testing 0a6dd6e using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1702

if (parameters.isParamValid("normal_smoothing_method"))
{
_penetration_locator.setNormalSmoothingMethod(parameters.get<std::string>("normal_smoothing_method"));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about these curly braces?

@moosebuild
Copy link
Contributor

Results of testing 0a6dd6e using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1703

@moosebuild
Copy link
Contributor

Results of testing 98badcf using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1705

@moosebuild
Copy link
Contributor

Results of testing 98badcf using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1706

@friedmud
Copy link
Contributor

Ben - are you going to do more here - or you think it's good enough at this point?

We raked you over the coals pretty well yesterday... so I'm ok with what's there at this point :-)

Thanks for playing along!

@bwspenc
Copy link
Contributor Author

bwspenc commented Apr 29, 2014

I'm reworking the code a little more to make it hopefully easier to follow. I'll push a revised commit shortly.

MechanicalContactConstraint is a general class for doing the full
set of contact formulations and friction models currently supported
by the DiracKernel-based mechanical contact system.

I've added a few 2D tests of this capability with this commit.  We're
working on a more comprehensive contact test suite.
@moosebuild
Copy link
Contributor

Results of testing 808d7ec using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1729

@bwspenc
Copy link
Contributor Author

bwspenc commented Apr 29, 2014

computeContactForce() now uses a switch/case that is more compatible with other areas of this file, and hopefully easier to follow. I looked into doing something similar for updateContactSet(), but it doesn't really make sense there.
I've made all other suggested style fixes, except for merging the nested if statements on lines 177 and 208. While those could certainly be merged without changing the meaning of the code, it's easier for me to wrap my head around this code the way they are written.

@moosebuild
Copy link
Contributor

Results of testing 808d7ec using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/1730

friedmud added a commit that referenced this pull request Apr 29, 2014
Add and test MechanicalContactConstraint ref #2816
@friedmud friedmud merged commit 397c5c2 into idaholab:devel Apr 29, 2014
@friedmud
Copy link
Contributor

Ok - looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants