-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and test MechanicalContactConstraint ref #2816 #3020
Conversation
Results of testing 88ff79a using moose_PR_pre_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1687 |
Results of testing 88ff79a using moose_PR_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1688 |
const Real _penalty; | ||
const Real _friction_coefficient; | ||
const Real _tension_release; | ||
bool _updateContactSet; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't follow the naming convention - and looks out of place since everything else does ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I'll fix it.
I modified my nasty looking code. Countless curly braces have been conserved for future generations. |
Results of testing 0a6dd6e using moose_PR_pre_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1702 |
if (parameters.isParamValid("normal_smoothing_method")) | ||
{ | ||
_penetration_locator.setNormalSmoothingMethod(parameters.get<std::string>("normal_smoothing_method")); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about these curly braces?
Results of testing 0a6dd6e using moose_PR_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1703 |
Results of testing 98badcf using moose_PR_pre_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1705 |
Results of testing 98badcf using moose_PR_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1706 |
Ben - are you going to do more here - or you think it's good enough at this point? We raked you over the coals pretty well yesterday... so I'm ok with what's there at this point :-) Thanks for playing along! |
I'm reworking the code a little more to make it hopefully easier to follow. I'll push a revised commit shortly. |
MechanicalContactConstraint is a general class for doing the full set of contact formulations and friction models currently supported by the DiracKernel-based mechanical contact system. I've added a few 2D tests of this capability with this commit. We're working on a more comprehensive contact test suite.
Results of testing 808d7ec using moose_PR_pre_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1729 |
computeContactForce() now uses a switch/case that is more compatible with other areas of this file, and hopefully easier to follow. I looked into doing something similar for updateContactSet(), but it doesn't really make sense there. |
Results of testing 808d7ec using moose_PR_test recipe: Passed on: linux View the results here: https://www.moosebuild.com/view_job/1730 |
Add and test MechanicalContactConstraint ref #2816
Ok - looks good! |
MechanicalContactConstraint is a general class for doing the full
set of contact formulations and friction models currently supported
by the DiracKernel-based mechanical contact system.
I've added a few 2D tests of this capability with this commit. We're
working on a more comprehensive contact test suite.