Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SideSetsAroundSubdomain should work with ParallelMesh #3139

Merged
merged 1 commit into from May 13, 2014

Conversation

jwpeterson
Copy link
Member

Forces this test to use SerialMesh. Maybe we should also put

mesh_mode = 'SERIAL'

in the tests file so these types of tests are actually skipped in parmesh builds?

Refs #2129.

@friedmud
Copy link
Contributor

Why doesn't this work on ParallelMesh ?

@friedmud
Copy link
Contributor

Instead of skipping this test - I would rather get to the bottom of it not working

@jwpeterson
Copy link
Member Author

I don't think any of the MeshModifiers that use the "flooding" strategy work with ParallelMesh, probably because it tries to access remote elems...

@friedmud
Copy link
Contributor

Is it just using the wrong iterator?

@permcody
Copy link
Member

Yes that's true, all of the MeshModifiers make assumptions about the mesh.
it would take some effort to fix this. Maybe we should actually throw an
error inside of the mesh modifier too? serial_only() or whatever that
macro is that does that

On Tue, May 13, 2014 at 10:34 AM, jwpeterson notifications@github.comwrote:

I don't think any of the MeshModifiers that use the "flooding" strategy
work with ParallelMesh, probably because it tries to access remote elems...


Reply to this email directly or view it on GitHubhttps://github.com//pull/3139#issuecomment-42979119
.

@permcody
Copy link
Member

No, more complicated than that. If you used the local iterators, you
wouldn't get the right flooding pattern as you cross a processor boundary
unless you exchange information.

On Tue, May 13, 2014 at 10:36 AM, Derek Gaston notifications@github.comwrote:

Is it just using the wrong iterator?


Reply to this email directly or view it on GitHubhttps://github.com//pull/3139#issuecomment-42979406
.

@friedmud
Copy link
Contributor

I gotcha - in that case: yes, we need to thrown an error if these try to get used with ParallelMesh.

@jwpeterson you implemented something like that already, right?

Also - make sure to put a ticket in to go see if this can be fixed (I understand it might take substantial work... but I would really like everything to work with ParallelMesh as much as possible).

@moosebuild
Copy link
Contributor

Results of testing e2ce1cc using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/2155

@jwpeterson
Copy link
Member Author

I checked and SideSetsAroundSubdomain doesn't actually flood() so it should work with ParallelMesh. Just added a patch to enable it, will squash and merge if it passes moosebuild.

@friedmud
Copy link
Contributor

Thanks John - that makes more sense to me (I didn't see why that one shouldn't work).

@moosebuild
Copy link
Contributor

Results of testing e2ce1cc using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/2156

@moosebuild
Copy link
Contributor

Results of testing 9d6ef4b using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/2164

The algorithm doesn't use flood().

Refs idaholab#2129.
@jwpeterson jwpeterson changed the title This test only works with serial mesh. SideSetsAroundSubdomain should work with ParallelMesh May 13, 2014
jwpeterson added a commit that referenced this pull request May 13, 2014
SideSetsAroundSubdomain should work with ParallelMesh
@jwpeterson jwpeterson merged commit 7da0c60 into idaholab:devel May 13, 2014
@jwpeterson jwpeterson deleted the sidesets_around_subdomain branch May 13, 2014 18:12
@moosebuild
Copy link
Contributor

Results of testing 9d6ef4b using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/2165

@moosebuild
Copy link
Contributor

Results of testing 3c23e8b using moose_PR_pre_test recipe:

Failed on: linux

View the results here: https://www.moosebuild.com/view_job/2171

1 similar comment
@moosebuild
Copy link
Contributor

Results of testing 3c23e8b using moose_PR_pre_test recipe:

Failed on: linux

View the results here: https://www.moosebuild.com/view_job/2171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants