Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed version info for Apps and framework. #4027

Merged
merged 1 commit into from
Oct 14, 2014

Conversation

shanestafford
Copy link

Addresses issue #4026. Adds detailed version information for repos in SVN, git, or git-svn and prints both the App version and the framework version when the exe is run.

This is a first stab. There are plenty of apps, and I don't really know how their makefiles look, but this should work for apps where make is executed from within the repo where the app lives.

The output for a famous app looks like this:

Framework Information:
App version:            derived from v0.0, git commit 091bd8c on 2014-10-09
MOOSE version:          git commit e538bba on 2014-10-09
PETSc Version:          3.4.5

@moosebuild
Copy link
Contributor

Results of testing 53354e6 using moose_PR_pre_check recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6450

@permcody
Copy link
Member

Looks good shane, I do have one request but it isn't essential for merging this. In MOOSE (test and examples) we see duplicate information:

App version:             git commit 53354e6 on 2014-10-10
MOOSE version:      git commit 53354e6 on 2014-10-10

Perhaps we can simply not print it if it's the same?

@permcody
Copy link
Member

Did you look into including this information in the Exodus file too?

@moosebuild
Copy link
Contributor

Results of testing 53354e6 using moose_PR_test_dbg recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6452

@moosebuild
Copy link
Contributor

Results of testing 53354e6 using moose_PR_test recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6451

@moosebuild
Copy link
Contributor

Results of testing 98849a5 using moose_PR_pre_check recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6467

@permcody
Copy link
Member

Shane noticed that this PR has a problem. If you compile an application like BISON, then compile the moose test application, then go back to run BISON again, you will get a different MOOSE version. This is because the moose test application will overwrite the shared header file with its own version. To solve this issue we really need multiple headers for each application. Marking this as under development.

@moosebuild
Copy link
Contributor

Results of testing 98849a5 using moose_PR_test recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6468

@moosebuild
Copy link
Contributor

Results of testing 98849a5 using moose_PR_test_dbg recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6469

Addresses issue idaholab#4026. Finds detailed version information for repos
in SVN, git, or git-svn. Auto-generates revision header files for
the apps and framework. Prints framework revision. (Apps can print
their own version info using the generated header.)
@shanestafford
Copy link
Author

This one lets the apps choose whether or not to print version information (it auto-generates a header for the app if a location is specified in the app's Makefile via APP_REV_HEADER). The MOOSE framework always prints its version.

@moosebuild
Copy link
Contributor

Results of testing 9a47781 using moose_PR_pre_check recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6526

@moosebuild
Copy link
Contributor

Results of testing 9a47781 using moose_PR_test recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6527

@moosebuild
Copy link
Contributor

Results of testing 9a47781 using moose_PR_test_dbg recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.com/view_job/6528

permcody added a commit that referenced this pull request Oct 14, 2014
Add detailed version info for Apps and framework.
@permcody permcody merged commit f161224 into idaholab:devel Oct 14, 2014
@shanestafford shanestafford deleted the detailed_version_info_4026 branch October 14, 2014 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants