Adding parsing for double indexed/separated fields

[snschune]

Concept of parsing double index objects. Half of it is missing still but I wanted to get feedback
before proceeding too far.

• this will need libMesh::print_helper(std::ostream & os, const std::vector<vector<P> >* param)
• should it support double indexed objects of type Point or RealVectorValue?
• specialization of dynamicCastAndExtractDoubleIndex for MooseEnum
• this will need a Moose unit test, but I am not sure how to set it up yet.

[permcody]

I'm not sure I want to support every type in the double syntax. It's unlikely that we'll use very many of them. I'd suggest we add the types you want and leave the rest out until there's a use case and better yet, a test case to support them.

[permcody]

This is looking pretty good so far.

[snschune]

@permcody testing in regular tests or unit tests?

[permcody]

Either is fine. You might find it painful to build a Parser object in the Unit Tests... I'm not sure though maybe it's easy.

[snschune]

I have added a single test for reading double indexed Reals.I realized that there will be an issue
with VariableName. Coupleable assumes that these come as vectors and hence coupledValue takes only one index. To enable double indexed coupled variables would probably require a lot of work, so I'd just disable this capability for now.
Opinions?
Do you need to test the Parser functions for all permissible data types?

[permcody]

Well that would be nice, but I still think we should pare down the list of permissible types. Do we really think we are going to need a double indexed list of function_names for instance? Let's just add the types we need now. If more needs arise later, we'll add PRs with tests later.

[snschune]

FunctionName and primitive types are actually the ones that we want in Rattlesnake. I'd definitely remove the following:

FileName, FileNameNoExtension, MeshFileName, MultiAppName,

but I could live with the unmentioned ones going as well. Once we trimmed this, I'll add tests
for all supported types.

[friedmud]

I actually vote for adding all the ones we can think of / all the ones
Sebastian cares to do right now. As long as they are tested, why not?

This is going to be a new "first class", supported input syntax: so let's
make it work like people expect...
On Wed, Mar 2, 2016 at 7:10 PM Sebastian Schunert notifications@github.com
wrote:

FunctionName and primitive types are actually one that we want in
Rattlesnake. I'd definitely remove the following:

FileName, FileNameNoExtension, MeshFileName, MultiAppName,

but I could live with the unmentioned ones going as well. Once we trimmed
this, I'll add tests
for all supported types.

—
Reply to this email directly or view it on GitHub
#6459 (comment).

[snschune]

This needs libmesh libMesh/libmesh#846
Is this going to be in the next libmesh update?

[permcody]

Yes, it'll be in the next one.

On Thu, Mar 3, 2016 at 3:49 PM Sebastian Schunert notifications@github.com
wrote:

This needs libmesh libMesh/libmesh#846
libMesh/libmesh#846
Is this going to be in the next libmesh update?

—
Reply to this email directly or view it on GitHub
#6459 (comment).

[permcody]

We should probably do this as a unit test at some point so we can test the succeeds and fails equally well. I won't make you do that for this test though. This will get us pretty far down the path towards doing that.

[snschune]

I am done with this for now and ready to take the heat.

[permcody]

👍

[YaqiWang]

I will suggest to create another PR for using this new capability in

https://github.com/idaholab/moose/blob/devel/framework/src/preconditioners/SingleMatrixPreconditioner.C

for the coupled_groups parameter.

That can clean the code up quite a bit.

[snschune]

Yes, why not deploy it.

2016-03-09 14:00 GMT-07:00 Yaqi notifications@github.com:

I will suggest to create another PR for using this new capability in

https://github.com/idaholab/moose/blob/devel/framework/src/preconditioners/SingleMatrixPreconditioner.C

for the coupled_groups parameter.

That can clean the code up quite a bit.

—
Reply to this email directly or view it on GitHub
#6459 (comment).

[snschune]

What uses SingleMatrixPreconditioner?
Note: we excluded NonlinearVariableName as type for double indexed parsing
because it is inconsistent with Coupleable which is made for a vector.

[dschwen]

It is used in a bunch of phase field examples and tests.