Address valgrind issue #8717
Merged
Address valgrind issue #8717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this failing the python tests?! @aeslaughter , any idea? |
permcody
approved these changes
Mar 13, 2017
| @@ -44,6 +44,8 @@ MemoryUsage::MemoryUsage(const InputParameters & parameters) | |||
| : GeneralPostprocessor(parameters), | |||
| _mem_type(getParam<MooseEnum>("mem_type").getEnum<MemType>()), | |||
| _value_type(getParam<MooseEnum>("value_type").getEnum<ValueType>()), | |||
| _value(0.0), | |||
| _peak_value(0.0), | |||
There was a problem hiding this comment.
Oh man! I even noticed that you didn't initialize these in my review but I figured it was ok because you set them to zero in initialize. I guess I should have gone with my gut...
|
I guess the variable that was only initialized on timeStepSetup didn't get initialized for output on initial (maybe neither did the other one...). |
|
Fixes the valgrind issue. Test failure is an unrelated python test. |
|
Job mooseutils/tests.vector_postprocessors failed, seeing if it is reproducible |
|
The valgrind test is "failed but allowed" due to a failing Json python unit test. Hopefully fixed in #8718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8619