Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output full path of missing parameter. #9137

Merged
merged 1 commit into from May 17, 2017

Conversation

brianmoose
Copy link
Contributor

The parser attaches a private parameter "parser_syntax" to each InputParameters that is the full
path of the object. These InputParameters are then stored in the Action.
For actions that inherit from MooseObjectAction, another InputParameters is created and
stored in _moose_object_pars. These are then passed into the Factory::create() which does a checkParams() on them. This is where the error message is generated and the "parser_syntax" isn't there to determine the full path.

I don't know if this is the correct fix. This just copies the "parser_syntax" parameter to the InputParameters that are stored in _moose_object_pars in MooseObjectAction. Also tries to use it during checkParams().

closes #9103

@moosebuild
Copy link
Contributor

Job Precheck:linux-gnu on 713d95d wanted to post the following:

Your code requires style changes.
In the top level of your repository, you can run:

git clang-format 62594b2e0c4c81dcbd71b9cd3e4116d21031754b

Alternatively, apply the patch found here.
You can directly apply the patch by running:

curl -s http://mooseframework.org/docs/PRs/9137/style.patch | git apply -v

@moosebuild
Copy link
Contributor

Job Moose Documentation:linux-clang on aaeb2a9 wanted to post the following:

View the site at http://mooseframework.org/docs/PRs/9137/site

@brianmoose
Copy link
Contributor Author

I do have a BISON patch ready to go.
The only change for BISON is for a couple of tests where they match against the missing parameter output with a partial path to the missing parameter.

@permcody permcody merged commit 2119619 into idaholab:devel May 17, 2017
@brianmoose brianmoose deleted the missing-param-9103 branch May 17, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants