Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Allow Bayesian Optimization to use Pre-trained GP ROM #2281

Closed
10 tasks done
wangcj05 opened this issue Mar 8, 2024 · 1 comment · Fixed by #2280
Closed
10 tasks done

[TASK] Allow Bayesian Optimization to use Pre-trained GP ROM #2281

wangcj05 opened this issue Mar 8, 2024 · 1 comment · Fixed by #2280
Assignees
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Mar 8, 2024


Issue Description

Is your feature request related to a problem? Please describe.
For experimental design, utilize existing dataset from experiment to guide the future exploration and exploitation will benefit optimal experimental design.

Describe the solution you'd like
Allow pre-trained GP ROM to be used in the Bayesian Optimization

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@wangcj05 wangcj05 added priority_minor task This tag should be used for any new capability, improvement or enanchment labels Mar 8, 2024
@wangcj05 wangcj05 self-assigned this Mar 8, 2024
@dylanjm
Copy link
Collaborator

dylanjm commented Mar 11, 2024

Approved to close via #2280

@dylanjm dylanjm closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants