Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyword error for required_realm #188

Closed
wants to merge 1 commit into from

Conversation

lepture
Copy link
Collaborator

@lepture lepture commented Jul 3, 2013

The keyword on request validator is required_realm, but it is called with a keyword valid_realms which could raise a KeywordError.

Suggestion:

There are realm and realms, it is not clear to see if it is a list or not. Let's make realm a string with whitespace and realms a list. Which means:

realm = 'email article'
realms = ['email', 'article']

@lepture lepture mentioned this pull request Jul 3, 2013
@lepture
Copy link
Collaborator Author

lepture commented Jul 3, 2013

Merging #189 instead.

I would keep it open, if you dislike 189, we can talk it here.

@lepture lepture closed this Jul 4, 2013
@lepture lepture deleted the valid_realm branch July 4, 2013 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant