Add log statements to except clauses #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjmc
reviewed
Jan 8, 2017
| @@ -34,13 +34,17 @@ def validate_request(self, uri, http_method='GET', | |||
| """ | |||
| try: | |||
| request = self._create_request(uri, http_method, body, headers) | |||
| except errors.OAuth1Error: | |||
| except errors.OAuth1Error as e: | |||
There was a problem hiding this comment.
Nitpick: single-letter variable names are hard to grep for. Consider err or error instead?
There was a problem hiding this comment.
Sure -- I was following the convention(?) in https://github.com/idan/oauthlib/blob/67f973ff7f98bb3d892a33eda67ba1dab3bddead/oauthlib/oauth2/rfc6749/endpoints/base.py#L58 though -- down to the logging message.
There was a problem hiding this comment.
Yeah, I don't love that one, either. But let sleeping dogs lie.
Thanks for changing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These log statements would help me not tear my hair out while implementing LTI tool providers.