-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove check on empty scopes for implicit grant flow #475
Conversation
Hi, if you take a look in the following test cases list you will see that this is not covered by any test: https://github.com/idan/oauthlib/blob/master/tests/oauth2/rfc6749/grant_types/test_implicit.py#L28-L41 Add this tests is important to this PR can you provide that? Ensure the existence of a test that in the case of not providing a scope the default defined in |
@akira-dev This build is failing. If you are still interested in this contribution please update your base and merge so that tests pass. If not. let us know and we will include it in our cleanup. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to merge this as is for 3.0.0.
I don't know why this test is made only in implicit grant type flow. Because in all others grant type flow if you don't provide scopes to get a token, token is generated with default_scopes of the client without errors. Moreover if you don't make this test in implicit grant type flow the behavior of this flow is the same as other grant type flows: it generate token with client default_scopes.