Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check on empty scopes for implicit grant flow #475

Merged
merged 7 commits into from
Sep 7, 2018

Conversation

akira-dev
Copy link
Contributor

@akira-dev akira-dev commented Apr 26, 2017

I don't know why this test is made only in implicit grant type flow. Because in all others grant type flow if you don't provide scopes to get a token, token is generated with default_scopes of the client without errors. Moreover if you don't make this test in implicit grant type flow the behavior of this flow is the same as other grant type flows: it generate token with client default_scopes.

@akira-dev akira-dev changed the title remove check on empty scopes remove check on empty scopes for implicit grant flow Apr 26, 2017
@duaneking
Copy link
Member

@akira-dev This build is failing. If you are still interested in this contribution please update your base and merge so that tests pass. If not. let us know and we will include it in our cleanup. Thanks!

@skion skion added this to the 3.0.0 milestone Jun 30, 2018
Copy link
Member

@skion skion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to merge this as is for 3.0.0.

@skion skion changed the title remove check on empty scopes for implicit grant flow Remove check on empty scopes for implicit grant flow Jul 1, 2018
@JonathanHuot JonathanHuot merged commit 36e7f50 into oauthlib:master Sep 7, 2018
@JonathanHuot JonathanHuot added Bug OAuth2-Provider This impact the provider part of OAuth2 labels Dec 3, 2018
@JonathanHuot JonathanHuot mentioned this pull request Dec 3, 2018
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug OAuth2-Provider This impact the provider part of OAuth2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants