Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicates saving with scores for cnn with numpy floats typecaste… #61

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

tanujjain
Copy link
Collaborator

Fix to issue #55.

Converts numpy floats to pure python floats to save to json as json can't save numpy floats.

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #61 into dev will decrease coverage by 0.07%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #61      +/-   ##
=========================================
- Coverage   95.17%   95.1%   -0.08%     
=========================================
  Files          16      16              
  Lines         622     633      +11     
=========================================
+ Hits          592     602      +10     
- Misses         30      31       +1
Impacted Files Coverage Δ
imagededup/methods/hashing.py 99.17% <ø> (ø) ⬆️
imagededup/utils/general_utils.py 100% <100%> (ø) ⬆️
imagededup/methods/cnn.py 97.89% <75%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7110ac3...28167be. Read the comment docs.

@tanujjain
Copy link
Collaborator Author

@clennan had a look at this with me and finds the implementation ok. So, we're good to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants