Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5063 Improve Unit Tests - MatchInv Tests #1144

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

tony-tspc
Copy link
Contributor

  • Add MatchInv test using standard costing and check Invoice Price Variance
  • General improvements using assertEquals where appropriate and
    comparing actual values rather than just >0
  • minor fixes to MProduct test

- Add MatchInv test using standard costing and check Invoice Price Variance 
- General improvements using assertEquals where appropriate and
  comparing actual values rather than just >0
- minor fixes to MProduct test
Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit bfecd41 into idempiere:master Jan 26, 2022
@tony-tspc tony-tspc deleted the IDEMPIERE-5063 branch January 26, 2022 02:04
CarlosRuiz-globalqss pushed a commit that referenced this pull request Feb 5, 2022
- Add MatchInv test using standard costing and check Invoice Price Variance 
- General improvements using assertEquals where appropriate and
  comparing actual values rather than just >0
- minor fixes to MProduct test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants