Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID #1735

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

https://idempiere.atlassian.net/browse/IDEMPIERE-5565

Tested successfully these cases for a virtual column in Test:
Both for Report and Info Window:

  • Search/Table with AD_Reference defined with DisplayColumn=ID
  • Search/Table with AD_Reference defined with DisplayColumn=Name
  • Table Direct

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

@hengsin
Copy link
Collaborator

hengsin commented Mar 16, 2023

hi @CarlosRuiz-globalqss , for the sake of consistency, shouldn't we follow the existing approach we use at line 728 to 729 instead ?

@CarlosRuiz-globalqss
Copy link
Collaborator Author

hi @CarlosRuiz-globalqss , for the sake of consistency, shouldn't we follow the existing approach we use at line 728 to 729 instead ?

done

Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hengsin hengsin merged commit eab0574 into idempiere:master Mar 17, 2023
CarlosRuiz-globalqss added a commit that referenced this pull request Mar 20, 2023
…ce is table with display column = ID (#1735)

* IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID

* - make it consistent with the actual approach
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-5565 branch April 4, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants