Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-4482 Mobile Improvements - Font #324

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

CarlosRuiz-globalqss
Copy link
Collaborator

Change font to improve the L&F
@hengsin
Copy link
Collaborator

hengsin commented Oct 26, 2020

I think that can all be moved to default/theme.css.dsp, below font-size: 14px; (line 21)

@CarlosRuiz-globalqss
Copy link
Collaborator Author

I think that can all be moved to default/theme.css.dsp, below font-size: 14px; (line 21)

Done

Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CarlosRuiz-globalqss , since the font-family setting at default/theme.css.dsp is global, we should remove the other unless it is different.

@CarlosRuiz-globalqss
Copy link
Collaborator Author

Hi @CarlosRuiz-globalqss , since the font-family setting at default/theme.css.dsp is global, we should remove the other unless it is different.

Done

Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try it out ...

@hengsin hengsin merged commit 86732d6 into idempiere:master Oct 27, 2020
@CarlosRuiz-globalqss CarlosRuiz-globalqss deleted the IDEMPIERE-4482 branch October 27, 2020 18:22
AndreaCh83 pushed a commit to idempiere-consulting/idempiere that referenced this pull request Nov 18, 2020
* IDEMPIERE-4482 Mobile Improvements - Font

Change font to improve the L&F

* Move font-family to generic definition in theme.css.dsp

* Remove unnecessary font-family settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants