Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on using "tidy evaluation" or not for column names #48

Open
lilyclements opened this issue Feb 11, 2022 · 2 comments
Open

Discussion on using "tidy evaluation" or not for column names #48

lilyclements opened this issue Feb 11, 2022 · 2 comments

Comments

@lilyclements
Copy link
Collaborator

We generally do not use tidy evaluation but should have a discussion on this soon.

@dannyparsons in some functions, such as climatic_missing, we use the tidy evaluation method.

I'll list here functions we use tidy evaluation in, and so we can change either these functions later - or the functions not listed here to update to tidy evaluation.

@lilyclements
Copy link
Collaborator Author

In addition - we use rlang::quos on output_CDT (and perhaps other functions) taken from R-Instat. For consistency we should change these too to whichever system we go for?

@dannyparsons
Copy link
Contributor

Maybe we should use one of these functions to demonstrate how the tidy evaluation could work? Seeing how it works with checkmate etc. to check its feasible. I don't mind having this inconsistency while we are deciding.

If it works well we can implement tidy evaluation throughout, otherwise we can change these to use strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants