Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 can register more than once with a single email address #5

Closed
jkim485 opened this issue Jun 22, 2015 · 8 comments
Closed

v1.0.0 can register more than once with a single email address #5

jkim485 opened this issue Jun 22, 2015 · 8 comments

Comments

@jkim485
Copy link

jkim485 commented Jun 22, 2015

Should this be allowed?

@raddick
Copy link
Contributor

raddick commented Jun 30, 2015

This is really a question about the portal. Leaving it open here for now until we're ready to test Mitya's new portal.

@thakar
Copy link

thakar commented Jun 30, 2015

Yeah it would make testing the portal very hard indeed if you couldn't
reuse emails (of course, it probably has no way of checking validity of
email addresses so you could use fake ones).

I thought casjobs did in fact enforce unique emails but clearly it must not
any more.

Ani

Aniruddha R. Thakar, Principal Research Scientist
Center for Astrophysical Sciences and
Institute for Data Intensive Engineering & Science (IDIES), JHU
3701 San Martin Drive, Baltimore MD 21218-2695
410-516-4850, thakar@jhu.edu, www.sdss.jhu.edu/~thakar

http://www.sdss.jhu.edu/%7Ethakar

We are all atheists about most of the gods that societies have ever
believed in. Some of us just go one god further. [Richard Dawkins]

On Tue, Jun 30, 2015 at 12:38 PM, raddick notifications@github.com wrote:

This is really a question about the portal. Leaving it open here for now
until we're ready to test Mitya's new portal.


Reply to this email directly or view it on GitHub
#5 (comment).

@raddick
Copy link
Contributor

raddick commented Jul 1, 2015

The current production CasJobs does indeed enforce unique emails. I just tried creating a new account with my current email, and got an error saying "Cannot create account; this email already exists."

Forget about testing - what about our end users? Do we want to allow multiple registrations on the same email address?

I don't think that allowing multiple registrations on an email hurts the user, but it does mean that we can't use email as the primary key in the users table.

Thoughts?

@thakar
Copy link

thakar commented Jul 1, 2015

We don't use email as PK anyway AFAIK, probably webservicesid or userid.
However, we do need to continue to enforce email uniqueness in general, to
discourage people from creating multiple accounts just to get more space,
or when they forget their credentials.

Ani

Aniruddha R. Thakar, Principal Research Scientist
Center for Astrophysical Sciences and
Institute for Data Intensive Engineering & Science (IDIES), JHU
3701 San Martin Drive, Baltimore MD 21218-2695
410-516-4850, thakar@jhu.edu, www.sdss.jhu.edu/~thakar

http://www.sdss.jhu.edu/%7Ethakar

Whoever heard of a hundred thousand animals rushing together to
butcher each other, as men do everywhere (during war)?
[Desiderius Erasmus]

On Wed, Jul 1, 2015 at 9:13 AM, raddick notifications@github.com wrote:

The current production CasJobs does indeed enforce unique emails. I just
tried creating a new account with my current email, and got an error saying
"Cannot create account; this email already exists."

Forget about testing - what about our end users? Do we want to allow
multiple registrations on the same email address?

I don't think that allowing multiple registrations on an email hurts the
user, but it does mean that we can't use email as the primary key in the
users table.

Thoughts?


Reply to this email directly or view it on GitHub
#5 (comment).

@jkim485
Copy link
Author

jkim485 commented Jul 1, 2015

I haven't seen a case using email address as PK. Agreed with Ani on enforcing email uniqueness .

@raddick
Copy link
Contributor

raddick commented Jul 2, 2015

OK, sounds like we've decided that we do want to enforce email uniqueness. Should we close this issue, then?

@raddick
Copy link
Contributor

raddick commented Jul 2, 2015

Oh, but the issue said that the user can register with more than one email address. That's not the behavior we want.

So this is no longer a question, but a bug. Changing labels accordingly.

@jkim485
Copy link
Author

jkim485 commented Oct 8, 2015

I think that this issue should be moved to single sign-on login portal.

@mikear69
please confirm it and close it.

@dimm0 dimm0 closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants