Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden folders #336

Merged
merged 2 commits into from
Sep 3, 2016
Merged

Hidden folders #336

merged 2 commits into from
Sep 3, 2016

Conversation

camilstaps
Copy link
Contributor

Folders matching any item in the hidden_folders setting are hidden from the user.

@idleberg
Copy link
Owner

Since both, folders and files, are stored in hidden_files, you should rename this accordingly. And I should think about renaming this to hidden_items in the next major release.

@camilstaps
Copy link
Contributor Author

Are you sure that hidden_files can contain folders? When I add a folder to this, it is still shown - and that is also what I understand from the code: https://github.com/idleberg/Bootstrap-Listr/blob/master/src/index.php#L554 is in a foreach($file_list as $item).

@idleberg
Copy link
Owner

idleberg commented Sep 3, 2016

Folders aren't ignored, that has bern an oversight. I will merge your change when you will use hidden_files. I see no use for two different settings, even if the naming is currently ambiguous.

@camilstaps
Copy link
Contributor Author

I see, now I understand what you meant :) Thanks!

@idleberg idleberg merged commit 29a7913 into idleberg:master Sep 3, 2016
@idleberg
Copy link
Owner

idleberg commented Sep 3, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants