Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins on GitHub should have one fewer levels of directory structure #13

Closed
obra opened this issue Jul 4, 2013 · 10 comments
Closed

Plugins on GitHub should have one fewer levels of directory structure #13

obra opened this issue Jul 4, 2013 · 10 comments
Assignees
Milestone

Comments

@obra
Copy link
Contributor

obra commented Jul 4, 2013

Right now, to "git co" a plugin into IdnoPlugins, I need to check it out elsewhere and ln -s it to get the "right" directory into the IdnoPlugins directory. If the content of the plugins were lifted up one level, the deploy-from-git process would be a lot easier.

@benwerd
Copy link
Member

benwerd commented Jul 5, 2013

That's true - I wasn't thinking about the deploy-from-git process as much as the upload-from-zip process. You could always pull the partial git tree though?

@obra
Copy link
Contributor Author

obra commented Jul 5, 2013

On Thu, Jul 04, 2013 at 05:56:17PM -0700, Ben Werdmuller wrote:

That's true - I wasn't thinking about the deploy-from-git process as much as the upload-from-zip process. You could always pull the partial git tree though?

I didn't think that worked. But I haven't poked in a long itme.

One reason to think about the "deploy from git" version of the process is how much easier it makes upgrades and updates.

@benwerd
Copy link
Member

benwerd commented Jul 5, 2013

Agree completely. I'll take a hard look at this a little later on today.

@ghost ghost assigned benwerd Jul 5, 2013
@demisflanagan
Copy link

I ran into the same issue and just moved the directory down the tree. It probably broke the git structure but it worked. It would be great if they cloned directly into the plugin directory.

@benwerd
Copy link
Member

benwerd commented Aug 22, 2013

Marking this as todo this weekend.

@mapkyca
Copy link
Member

mapkyca commented Aug 28, 2013

Ditto.

Current directory structure makes deployment a nightmare.

@benwerd
Copy link
Member

benwerd commented Aug 28, 2013

Sorry for the delay, folks. This has been a low-idno month, but September will see development ramp right back up. I intend to get to this then.

@mapkyca
Copy link
Member

mapkyca commented Aug 30, 2013

For others in the same position reading this; Git will store symlinks in the repo (providing your OS supports it), so for deploy, create a separate directory and do your submodule checkouts into those, then symlink from IdnoPlugins.

This'll work providing plugins don't make assumptions based on location (which they shouldn't)

@Phyks
Copy link
Contributor

Phyks commented Dec 26, 2014

This would be a really great improvement of the plugin system imo :)

@benwerd
Copy link
Member

benwerd commented Jul 28, 2015

This was completed ... ooh, well over a year ago. Closed! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants