Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow locale override #141

Open
idpaterson opened this issue Nov 20, 2016 · 1 comment
Open

Allow locale override #141

idpaterson opened this issue Nov 20, 2016 · 1 comment

Comments

@idpaterson
Copy link
Owner

The workflow supports only English menu language and task entry keywords (due, remind me, etc), but dates need to be entered in the user's locale. This is never particularly obvious and sometimes it just doesn't work. I'm trying to improve date handling for other locales.

I added a quick "force English" preference in response to this issue but do not plan to release that. Instead, a preference should be added that allows the user to select either their system locale or one of the other built-in parsedatetime locales. This screen can show examples from Calendar.ptc.locale.* like month names, weekday names, and "today" in each language. This should also include reorganization of the preferences as described in #106.

Discussion

  1. Should English be the default, requiring an explicit preference change to use a different locale?
    • This might avoid confusion since the main documentation and examples for the workflow will work regardless of locale
  2. Would anyone be willing to help me write test cases for date expressions in German, Russian, French, Spanish, Dutch, or Portuguese in parsedatetime over the next few months?
@mihan007
Copy link

  1. Yes
  2. I'm going to help with Russian. If you can point me to preferrable format of test cases that would be great. As of now I may provide "Russian" => "English" datetime pairs and vice versa.

@idpaterson idpaterson removed their assignment Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants