Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organizing test resources to packages #105

Closed
sebastian-peter opened this issue Jan 24, 2022 · 0 comments · Fixed by #127
Closed

Re-organizing test resources to packages #105

sebastian-peter opened this issue Jan 24, 2022 · 0 comments · Fixed by #127
Assignees
Labels
code quality Code readability or efficiency is improved

Comments

@sebastian-peter
Copy link
Member

Test data can be moved to the respective packages that it is needed in. This way, it is more obvious to which test the data belongs and vice versa. Also, getClass.getResource() works well with this, as only the path relative to the own package path needs to be stated.

For example, the contents of it-data/primaryService can be moved into some directory in edu/ie3/simona/service/primary. The full path then does not need to be stated when using getClass.getResource().

As discussed with @t-ober, and @johanneshiry @ckittl you are welcome to give your opinion about this as well.

@sebastian-peter sebastian-peter added the code quality Code readability or efficiency is improved label Jan 24, 2022
@sebastian-peter sebastian-peter self-assigned this Jan 24, 2022
@sebastian-peter sebastian-peter changed the title Organizing test resources in project Re-organizing test resources to packages Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or efficiency is improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant