Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissing the Warning on Gatsby 3+ #58

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

nitzanvolman
Copy link
Contributor

@nitzanvolman nitzanvolman commented Aug 27, 2021

based on the discussion on
#40
and these instructions for plugin maintainers.
https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v2-to-v3/#for-plugin-maintainers

The plugin itself works for me for a while now on the latest 3 gatsby without issue.

Closes #40

Description

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and yarn fix runs successfully.
  • I have run yarn api:generate and updated the README documentation where necessary.
  • New code is unit tested and all current tests pass when running yarn test && yarn test:e2e.

based on the discussion on 
ifiokjr#40
and these instructions for plugin maintainers. 
https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v2-to-v3/#for-plugin-maintainers

The plugin itself works for me for a while now on the latest 3 gatsby without issue.
@ifiokjr
Copy link
Owner

ifiokjr commented Aug 28, 2021

Thanks for creating the PR. I'll merge it once it builds.

@nitzanvolman
Copy link
Contributor Author

nitzanvolman commented Aug 28, 2021 via email

@ifiokjr ifiokjr merged commit 173d5df into ifiokjr:master Aug 30, 2021
github-actions bot pushed a commit that referenced this pull request Aug 30, 2021
## [1.8.0](v1.7.0...v1.8.0) (2021-08-30)

### Features

* add support for `gatsby@3` ([#58](#58)) ([173d5df](173d5df))
@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

santa512 added a commit to santa512/gatsby-plugin-next-seo that referenced this pull request Mar 4, 2024
stacksculptor added a commit to stacksculptor/Resilio that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Gatsby 3.0
2 participants