Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded compiler flags prevent debugging #267

Closed
graugans opened this issue Oct 5, 2020 · 3 comments
Closed

Hard coded compiler flags prevent debugging #267

graugans opened this issue Oct 5, 2020 · 3 comments
Assignees

Comments

@graugans
Copy link
Member

graugans commented Oct 5, 2020

Describe the bug
The hard coded compiler flag -s prevents the creation of debug symbols regardless of the build type.
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-literal-suffix -s") This is found in line 53 in the top-level CMakeLists.txt.

Expected behavior
The -s shall be removed from the flags. For the -Wno-literal-suffix a check needs to be performed if this is needed and if there are ways to configure this through CMake. Cause this might result in different behaviours when using a different cpp compiler like CLang.

@graugans
Copy link
Member Author

I just checked building with Clang 6. which does not recognize both of the CXX flags.

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 10, 2022
@github-actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants