Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing issues #12

Closed
DavidMann10k opened this issue Apr 1, 2020 · 6 comments
Closed

Spacing issues #12

DavidMann10k opened this issue Apr 1, 2020 · 6 comments

Comments

@DavidMann10k
Copy link
Collaborator

There are multiple spacing issues on this page:
https://igdatc.github.io/events/main-meeting/2020/01/22/watchmen_ar.html

  • The large image has no margin underneath.
  • The sections don't appear to have enough spacing between them.
@mgrider
Copy link
Contributor

mgrider commented Apr 1, 2020

Worth noting this applies to all meeting events so far. Many of them have some <br \> tags added to manually add spacing. My preferred solution is to add padding or margin above the headers on these pages, and remove all the extra tags. (This might require identifying just these pages somehow in the CSS.)

Also, the size of the image should probably be controlled by CSS as well. (Ideally, to fit the screen width somehow. I'm sure this is possible.)

@DavidMann10k
Copy link
Collaborator Author

Just to back up a little bit. The problem I had with how the margin was added to all headers is how it added space between headers that were positioned over and under each other and headers contained in cards.

When looking at the problem that you were trying to solve, my diagnosis was the lack of spacing under elements preceding headers and the lack of HTML was a problem.

On a different website I might add semantic HTML, specifically a <section> and then adding margin to the bottom of those. I think this is more descriptive. I don't like this idea for this project, because it makes us involve more HTML in our, beautifully, pure markdown. I'd prefer to be able to solve this in a way that allows us to keep our content markdown and simple.

When using bootstrap I generally try to avoid having large style sheets.
tags might actually not be a inelegant solution here compared to the alternative of polluting the markdown with containers, ids and inline styles or bootstrap classes.

@DavidMann10k
Copy link
Collaborator Author

Oh, duh. I should have thought of this when I was adding .img-fluid to that image, but now there's also a margin below it, which solves another issue here. 2e1e71a

@mgrider
Copy link
Contributor

mgrider commented Apr 1, 2020

The problem I had with how the margin was added to all headers is how it added space between headers that were positioned over and under each other and headers contained in cards.

Thanks for clarifying this. I wasn't sure what prompted this as an issue in the first place.

I definitely agree that we should try and keep our "beautifully pure markdown". ;)

@DavidMann10k
Copy link
Collaborator Author

Check out d457e1c for some fancy spacing changes. This commit should resolve this issue.

In addition to fiddling with the spacing of the event layout, it adds extra space to the top of any <hx> that follows a <p>.

This allows the <br> to be removed from markdown files in this commit: 02e6a46

@mgrider
Copy link
Contributor

mgrider commented Jul 20, 2022

This seems fixed, I think!

@mgrider mgrider closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants