Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a new tag #4

Closed
caarlos0 opened this issue Feb 1, 2022 · 2 comments
Closed

create a new tag #4

caarlos0 opened this issue Feb 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@caarlos0
Copy link
Contributor

caarlos0 commented Feb 1, 2022

running

go mod init foo
go get github.com/IGLOU-EU/go-wildcard
echo 'package main

import (
	"fmt"

	wildcard "github.com/IGLOU-EU/go-wildcard"
)

func main() {
    str := "daaadabadmanda"
    
    pattern := "da*da*da*"
    result := wildcard.MatchSimple(pattern, str)
	fmt.Println(str, pattern, result)

    pattern = "?a*da*d?*"
    result = wildcard.Match(pattern, str)
	fmt.Println(str, pattern, result)
}
' > main.go

go mod tidy

results in both github.com/IGLOU-EU/go-wildcard v1.0.2 and git.iglou.eu/Imported/go-wildcard v1.0.1 being added to go.mod and go.sum.

My guess, after looking into the commits and some other things:

  • changed the path on go.mod in d62667c
  • released v1.0.2
  • a couple of hours later, noticed the import of the old path was still in the test file, fixed in commit 5dbd249
  • deleted tag v1.0.2 and tagged it again

At that point, Go mod proxy had already cached the broken version, so when you go get you get that one instead of the intended one.

My suggestion would be to release a v1.0.3 to fix that.

cc/ @muesli

Cheers!

@IGLOU-EU IGLOU-EU added the bug Something isn't working label Feb 1, 2022
@IGLOU-EU
Copy link
Owner

IGLOU-EU commented Feb 1, 2022

I will do it as soon as possible! Thank you very much for this issue @caarlos0 !

@IGLOU-EU
Copy link
Owner

IGLOU-EU commented Feb 5, 2022

Check ! Thank again :)

@IGLOU-EU IGLOU-EU closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants