Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.50 upgrade adjustment #3842

Closed
RaulBernal opened this issue Dec 15, 2023 · 0 comments · Fixed by #3844
Closed

v0.50 upgrade adjustment #3842

RaulBernal opened this issue Dec 15, 2023 · 0 comments · Fixed by #3844

Comments

@RaulBernal
Copy link
Contributor

Describe the bug
The official Cosmos-SDK guide about upgrading to v0.50.x says When using depinject / app v2, the a tx config should be recreated from the txConfigOpts to use NewGRPCCoinMetadataQueryFn instead of depending on the bank keeper (that is used in the server).
https://github.com/cosmos/cosmos-sdk/blob/release/v0.50.x/UPGRADING.md#client

But Ignite scaffolded code doesn't observe this change, using the legacy way:
https://github.com/BitCannaGlobal/bcna/blob/eb1a355a722c901455565134a745c3ab26d5c7d1/cmd/bcnad/cmd/root.go#L85

To reproduce
Steps to reproduce the behavior:

  1. Scaffold a new chain
  2. Check and compare the txConfigOpts.EnabledSignModes assignment
  3. Compare with Official Upgrading guide

What version are you using?

v0.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant