Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templates): set init-chainer when custom modules #4184

Merged
merged 4 commits into from
Jun 13, 2024
Merged

fix(templates): set init-chainer when custom modules #4184

merged 4 commits into from
Jun 13, 2024

Conversation

julienrbrt
Copy link
Member

Closes: #4140

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Jun 7, 2024
toschdev
toschdev previously approved these changes Jun 10, 2024
View reviewed changes
salmad3
salmad3 previously approved these changes Jun 13, 2024
View reviewed changes
ignite/templates/app/files-consumer/app/app.go.plush Outdated Show resolved Hide resolved
ignite/templates/app/files-consumer/app/app.go.plush Outdated Show resolved Hide resolved
ignite/templates/app/files/app/app.go.plush Outdated Show resolved Hide resolved
ignite/templates/app/files/app/app.go.plush Outdated Show resolved Hide resolved
@julienrbrt @salmad3 @Pantani
Apply suggestions from code review
96fce43 
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@julienrbrt julienrbrt dismissed stale reviews from salmad3 and toschdev via 96fce43 June 13, 2024 13:39
@julienrbrt julienrbrt requested a review from Pantani June 13, 2024 13:40
@mergify mergify bot merged commit ff7ce85 into main Jun 13, 2024
48 checks passed
@mergify mergify bot deleted the julien/set-initchainer branch June 13, 2024 14:36
mergify bot pushed a commit that referenced this pull request Jun 13, 2024
@julienrbrt @mergify
fix(templates): set init-chainer when custom modules (#4184)
776a2b8 
Closes: #4140
(cherry picked from commit ff7ce85)
@mergify mergify bot mentioned this pull request Jun 13, 2024
Merged
julienrbrt added a commit that referenced this pull request Jun 13, 2024
@mergify @julienrbrt
fix(templates): set init-chainer when custom modules (backport #4184) (…
302035e 
…#4188)

* fix(templates): set init-chainer when custom modules (#4184)

Closes: #4140
(cherry picked from commit ff7ce85)

* fix changelog

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
@BrewTestBot BrewTestBot mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@salmad3 salmad3 salmad3 approved these changes

@toschdev toschdev toschdev left review comments

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@julienrbrt julienrbrt

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade error: SetIndex requires index to not be set
4 participants
@julienrbrt @Pantani @toschdev @salmad3