Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake message types #159

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix cmake message types #159

merged 1 commit into from
Feb 26, 2021

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Feb 25, 2021 •
edited

🦟 Bug fix

Same fix as gazebosim/gz-tools#41

Summary

Print CMake errors with SEND_ERROR type, and warnings with WARNING type.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@mabelzhang
fix cmake message types
560e5b4 
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Feb 25, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Feb 25, 2021
@mabelzhang mabelzhang moved this from Inbox to In review in Core development Feb 25, 2021
@mabelzhang mabelzhang merged commit 96faa49 into ign-cmake2 Feb 26, 2021
Core development automation moved this from In review to Done Feb 26, 2021
@mabelzhang mabelzhang deleted the mabelzhang/fix_cmake_msg branch February 26, 2021 01:52
@adlarkin adlarkin mentioned this pull request Feb 26, 2021
Merged
@chapulina chapulina mentioned this pull request Mar 25, 2021
Open
@chapulina chapulina mentioned this pull request Apr 26, 2021
Closed
7 tasks
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@adlarkin adlarkin Awaiting requested review from adlarkin

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mabelzhang @chapulina