mimic joint plugin added

[addy1997]

Summary

A simple plugin to mimic joint.

Files include

• MimicJoint.hh
• MimicJoint.cc
• CmakeLists.txt
• README.md (for instructions to generate .so file)

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

[scpeters]

this looks like a port of the following gazebo classic plugin:

• https://github.com/roboticsgroup/roboticsgroup_gazebo_plugins/blob/master/src/mimic_joint_plugin.cpp

there are some API's that are not supported in ignition-gazebo

[addy1997]

this looks like a port of the following gazebo classic plugin:

* https://github.com/roboticsgroup/roboticsgroup_gazebo_plugins/blob/master/src/mimic_joint_plugin.cpp

there are some API's that are not supported in ignition-gazebo

This is a system plugin. I went through the code twice to examine the namespace/structure/syntax used and it was similar to other (supported) plugins. Could you elaborate more on what exactly in my code or the API needs to be changed in order to make it workable in ign gazebo?

[ahcorde]

Hi @addy1997,

I can see that this package is using ROS. This repository should not contain any kind of ROS dependency. This is the strong reason why we should refuse this contribution. This package should live in its own repository.

[addy1997]

Hi @addy1997,

I can see that this package is using ROS. This repository should not contain any kind of ROS dependency. This is the strong reason why we should refuse this contribution. This package should live in its own repository.

Hi @ahcorde,

Yes, this is a valid point. Is there a repo for ros_ign gazebo plugins where I can contribute this? Actually, this plugin is useful for many applications.

[ahcorde]

Here is the ros_ign repository. There are different ROS versions.

I will close this issue.