-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize wireframes #314
Visualize wireframes #314
Conversation
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor nit
// create visual | ||
VisualPtr visual = scene->CreateVisual(); | ||
ASSERT_NE(nullptr, visual); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXPECT_EQ(false, visual->Wireframe()); | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
@osrf-jenkins retest this please |
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
Changed scene name to "scene7" since "scene6" is used in |
@osrf-jenkins retest this please |
1 similar comment
@osrf-jenkins retest this please |
The Camera test failure is unrelated |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: |
* Add wireframe mode Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com> * Fix visual test Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com> * Change scene name Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: Atharva Pusalkar atharvapusalkar18@gmail.com
🎉 New feature
Summary
Adds wireframe mode to visuals in OGRE 1 and 2. This PR targets Ignition Fortress since the changes break the ABI.
OGRE 2
![wireframe_ign_f](https://user-images.githubusercontent.com/39728574/116821979-0610a700-ab9a-11eb-9829-9a24f50ed73d.gif)
OGRE 1
![wireframe_ign_f_ogre](https://user-images.githubusercontent.com/39728574/116821984-0d37b500-ab9a-11eb-899a-e9d1b84555b5.gif)
Test it
Test it with wireframes.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge