Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error caused by missing comma. #28

Merged

Conversation

nuclearsandwich
Copy link

I assume this is just an oversight but it's been over a year since I've looked at bazel build files so maybe this comma was strategically absent. But it's causing a syntax error when I try the reference build:

ERROR: /ignition/ign_tools/BUILD.bazel:100:9: syntax error at '"//ign_launch"': expected ]
ERROR: package contains errors: ign_tools
DEBUG: /ignition/ign_bazel/qt.bzl:86:14: src/gui/GuiFileHandler.hh gui/GuiFileHandler.hh
DEBUG: /ignition/ign_bazel/qt.bzl:86:14: include/ignition/gazebo/gui/Gui.hh ignition/gazebo/gui/Gui.hh
DEBUG: /ignition/ign_bazel/qt.bzl:86:14: include/ignition/gazebo/gui/GuiEvents.hh ignition/gazebo/gui/GuiEvents.hh
DEBUG: /ignition/ign_bazel/qt.bzl:86:14: include/ignition/gazebo/gui/GuiRunner.hh ignition/gazebo/gui/GuiRunner.hh
DEBUG: /ignition/ign_bazel/qt.bzl:86:14: include/ignition/gazebo/gui/GuiSystem.hh ignition/gazebo/gui/GuiSystem.hh
DEBUG: /ignition/ign_bazel/qt.bzl:86:14: include/ignition/gazebo/gui/TmpIface.hh ignition/gazebo/gui/TmpIface.hh
ERROR: error loading package 'ign_tools': Package 'ign_tools' contains errors

@chapulina chapulina requested review from JShep1 and mjcarroll and removed request for caguero September 1, 2020 17:00
@mjcarroll mjcarroll merged commit 31313dc into gazebosim:bazel Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants