Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated material spec #644

Merged
merged 1 commit into from
Jul 29, 2021
Merged

updated material spec #644

merged 1 commit into from
Jul 29, 2021

Conversation

jennuine
Copy link
Collaborator

🦟 Bug fix

Related to #639, changes will need to be ported to later versions to fully resolve.

Summary

Added missing //environment_map from //material/pbr/specular specification.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine requested a review from azeey July 28, 2021 17:55
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 28, 2021
@jennuine jennuine merged commit 99d0250 into sdf9 Jul 29, 2021
@jennuine jennuine deleted the jennuine/material_spec branch July 29, 2021 00:51
jennuine added a commit that referenced this pull request Jul 29, 2021
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants