Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Item parsing error lacking detailed information #20

Closed
Flemmli97 opened this issue Dec 29, 2019 · 4 comments
Closed

[Improvement] Item parsing error lacking detailed information #20

Flemmli97 opened this issue Dec 29, 2019 · 4 comments
Assignees

Comments

@Flemmli97
Copy link

Describe the bug
DROP action only allows vanilla item values. This is cause net.minecraft.command.arguments.ItemParser looks in the vanilla item registry and not the forge one.

To Reproduce
Add in a modded item to a DROP action and it wont load.

Version (please complete the following information):

  • OS: MAC
  • TwitchSpawn Version: 0.4.9
  • Forge Version: 1.12.2-14.23.5.2847
@Flemmli97 Flemmli97 added the bug label Dec 29, 2019
@iGoodie
Copy link
Owner

iGoodie commented Dec 29, 2019

It works with modded items as well. Could you share your TSL rule as well? You might be having a malformed item string in it

@Flemmli97
Copy link
Author

nvm. it worked. item name was wrong

@iGoodie
Copy link
Owner

iGoodie commented Dec 29, 2019

But I believe more detailed info on which part of the item string is wrong could be so handy! Also I believe someone in the Discord server also made me realize that. So i’m reopening the issue but changing the topic of it! 🎉

@iGoodie iGoodie reopened this Dec 29, 2019
@iGoodie iGoodie changed the title DROP only using vanilla items [Improvement] Item parsing error lacking detailed information Dec 29, 2019
@iGoodie iGoodie added enhancement and removed bug labels Dec 29, 2019
@iGoodie iGoodie self-assigned this Dec 29, 2019
@iGoodie
Copy link
Owner

iGoodie commented Jan 1, 2020

With 55df8d6 invalid item parsing now provides more information, instead of a generic invalid item message 🎉

@iGoodie iGoodie closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants