Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow runtime selection of audio driver #106

Closed
igorski opened this issue Dec 30, 2019 · 1 comment
Closed

Allow runtime selection of audio driver #106

igorski opened this issue Dec 30, 2019 · 1 comment
Assignees
Labels
improvement Enhancing existing functionality

Comments

@igorski
Copy link
Owner

igorski commented Dec 30, 2019

Currently the engine must be compiled to either use OpenSL or AAudio as the driver. While AAudio promises better performance, OpenSL has a wider range of support.

Additionally, the unit tests use a mocked audio driver which is activated using a compiler directive. This greatly complicates building the library and running unit tests by not being able to do so side-by-side.

Make the engine a runtime option where the DriverAdapter is able to return the requested driver as appropriate. Update the CMakeLists.txt file to create mwengine as a shared library, remove the conditional for RUN_TESTS and make mwengine_unittest link to the shared mwengine. The entry point for unit tests (main.cpp) should auto select the mocked audio driver.

Update the README section on unit tests and "note on .. drivers"

@igorski igorski added the improvement Enhancing existing functionality label Dec 30, 2019
@igorski igorski self-assigned this Dec 31, 2019
@igorski
Copy link
Owner Author

igorski commented Jan 1, 2020

Addressed in 7ab3d10

@igorski igorski closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Enhancing existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant