Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdeps #1430

Closed
maelle opened this issue Jul 17, 2024 · 19 comments
Closed

revdeps #1430

maelle opened this issue Jul 17, 2024 · 19 comments
Milestone

Comments

@maelle
Copy link
Contributor

maelle commented Jul 17, 2024

No description provided.

@maelle maelle added this to the 2.0.4 milestone Jul 17, 2024
@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle
Copy link
Contributor Author

maelle commented Jul 17, 2024

ropensci/skynet#11

@maelle

This comment was marked as resolved.

@maelle
Copy link
Contributor Author

maelle commented Jul 17, 2024

rcmfs also uses from() instead of .from() but I could not locate the package source so we'll have to email the maintainer.

@maelle

This comment was marked as outdated.

@maelle

This comment was marked as outdated.

@maelle
Copy link
Contributor Author

maelle commented Jul 17, 2024

Reg BCT, I do not know where the package source is. I think #1431 will fix the problem on our side.

I however note that BCT should update its usage of igraph:

https://github.com/cran/BCT/blob/23e22470683b417c6da33cd3c55ab2c29d8670cf/R/process_bct.R#L46

should use make_lattice(), for instance.

@maelle

This comment was marked as resolved.

@krlmlr
Copy link
Contributor

krlmlr commented Jul 19, 2024

BCT still shows failures, unfortunately.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle
Copy link
Contributor Author

maelle commented Sep 5, 2024

can we close this @krlmlr

@krlmlr
Copy link
Contributor

krlmlr commented Sep 5, 2024

New results are incoming.

@krlmlr
Copy link
Contributor

krlmlr commented Oct 17, 2024

Rerunning, for the last time for this release I hope.

@krlmlr
Copy link
Contributor

krlmlr commented Oct 19, 2024

We somehow missed manynet, stocnet/manynet#98 .

@szhorvat
Copy link
Member

Hope it's not a problem I opened that issue ...

@krlmlr
Copy link
Contributor

krlmlr commented Oct 21, 2024

Not at all, to the contrary -- thanks!

@krlmlr krlmlr closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants