Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs in rinterface_extra.c #1454

Open
maelle opened this issue Aug 20, 2024 · 2 comments
Open

TODOs in rinterface_extra.c #1454

maelle opened this issue Aug 20, 2024 · 2 comments
Labels

Comments

@maelle
Copy link
Contributor

maelle commented Aug 20, 2024

rinterface_extra.c has

  • 7 TODOs /* TODO: serialization */
  • 1 TODO
  /* TODO: Change igraph_i_graphlets_project to igraph_graphlets_project, because
   * we should not depend on non-public functions from igraph.

Are those still relevant? @szhorvat @Antonov548

@maelle maelle added the c code label Aug 20, 2024
@Antonov548
Copy link
Contributor

rinterface_extra.c has

  • 7 TODOs /* TODO: serialization */
  • 1 TODO
  /* TODO: Change igraph_i_graphlets_project to igraph_graphlets_project, because
   * we should not depend on non-public functions from igraph.

Are those still relevant? @szhorvat @Antonov548

I'm not sure what /* TODO: serialization */ mean, it's something old.

Another TODO regarding igraph_i_graphlets_project seems relevant and should be fixed.

@maelle
Copy link
Contributor Author

maelle commented Aug 27, 2024

@Antonov548 Thank you!

  • Could we remove the one about serialization then?
  • How much work would be involved in fixing the TODO related to igraph_i_graphlets_project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants