Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage from a module #5

Closed
fb55 opened this issue Sep 16, 2012 · 4 comments
Closed

Allow usage from a module #5

fb55 opened this issue Sep 16, 2012 · 4 comments

Comments

@fb55
Copy link

fb55 commented Sep 16, 2012

It would be great if this library wouldn't require to be run using bin/spdyproxy. The most important issue is the heavy usage of colors methods inside lib/server.js. colors isn't required by the file, which leads to unexpected bugs.

Plus, the API could be properly documented.

@igrigorik
Copy link
Owner

Hmm, yeah that's a good idea. For colors, I'm assuming the actual dependency is not an issue?

@fb55
Copy link
Author

fb55 commented Sep 16, 2012

Not at all, but messages should be logged from bin/spdyproxy, as they are also part of the CLI. Please separate the logic :)

@chemhack
Copy link
Contributor

Is anyone working on this already?

@igrigorik
Copy link
Owner

@chemhack not that I'm aware of.

@fb55 fb55 closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants