Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf::parse_object prints parsed contents #97

Closed
JohnScience opened this issue Jun 28, 2024 · 1 comment
Closed

pdf::parse_object prints parsed contents #97

JohnScience opened this issue Jun 28, 2024 · 1 comment
Assignees

Comments

@JohnScience
Copy link
Collaborator

I assume that you've forgotten to comment out the debug-printing. I'll make a PR with the fix soon.

@JohnScience
Copy link
Collaborator Author

JohnScience commented Jun 28, 2024

While reading the source code, I discovered that

  • The project doesn't utilize cargo fmt (yet). It's an issue for collaboration
  • The project seems to use println! for reporting warnings. Instead, it's a good idea to use dedicated logging crates. See the log crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant