Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic versioning with comment (e.g. 4.0.0-comment) after patch not working with IG Publisher #11

Closed
oliveregger opened this issue Apr 15, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@oliveregger
Copy link
Contributor

Issue

package name 4.0.0-comment does not work with IG Publisher for dependent packages: Failed to resolve package ihe.mhd.fhir#4.0.0-comment from server: http://packages.fhir.org and Error reading http://ihe.net/fhir/ihe.mhd.fhir/4.0.0-comment/package.tgz

The issue is that current tooling does not accept suffix -comment (pre-release and build metadata)

Proposed Change
For this review no issues since master branch is the same, however for a next version it would be helpful to have a specific version for pubic commit.

Priority:

  • Low: Typo or other minor classification that an editor can manage. Requires no group discussion.
@JohnMoehrke
Copy link
Contributor

I thought that this was the recommendation... the published version coming out of comment resolution will be 4.0.0, so the problem should be short lived. Presumably the IG-Publisher will eventually have some kind of support for this concept.

@JohnMoehrke
Copy link
Contributor

I think the other problem is that I failed to send in the ig-registry pull-request. It was not part of the process documentation so I failed to do it. Now my pull-request is behind.

@JohnMoehrke JohnMoehrke self-assigned this Apr 28, 2021
@JohnMoehrke
Copy link
Contributor

also, IHE tends not to archive the public-comment version... so this will go away with final publication.

@JohnMoehrke JohnMoehrke added this to the 4.0.0 milestone Apr 28, 2021
@JohnMoehrke JohnMoehrke added the documentation Improvements or additions to documentation label May 5, 2021
@JohnMoehrke
Copy link
Contributor

@oliveregger indicates there is a RSS method for IHE as a whole to publish new IG.

@JohnMoehrke JohnMoehrke removed this from the 4.0.0 milestone May 12, 2021
@JohnMoehrke JohnMoehrke removed their assignment May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants